Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump leaflet-environmental-layers from 2.4.3 to 2.4.5 #10034

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 17, 2021

Bumps leaflet-environmental-layers from 2.4.3 to 2.4.5.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [leaflet-environmental-layers](https://github.com/publiclab/leaflet-environmental-layers) from 2.4.3 to 2.4.5.
- [Release notes](https://github.com/publiclab/leaflet-environmental-layers/releases)
- [Commits](https://github.com/publiclab/leaflet-environmental-layers/commits)

---
updated-dependencies:
- dependency-name: leaflet-environmental-layers
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file JavaScript labels Aug 17, 2021
@gitpod-io
Copy link

gitpod-io bot commented Aug 17, 2021

@codeclimate
Copy link

codeclimate bot commented Aug 17, 2021

Code Climate has analyzed commit c44b64f and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Aug 17, 2021

Codecov Report

Merging #10034 (c44b64f) into main (f41f8e7) will decrease coverage by 0.08%.
The diff coverage is 82.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #10034      +/-   ##
==========================================
- Coverage   82.13%   82.05%   -0.09%     
==========================================
  Files          98       98              
  Lines        5968     5974       +6     
==========================================
  Hits         4902     4902              
- Misses       1066     1072       +6     
Impacted Files Coverage Δ
app/models/tag.rb 93.26% <44.44%> (-4.27%) ⬇️
app/controllers/images_controller.rb 70.27% <100.00%> (ø)
app/controllers/notes_controller.rb 85.09% <100.00%> (+0.22%) ⬆️
app/controllers/tag_controller.rb 80.42% <100.00%> (ø)
app/helpers/application_helper.rb 87.62% <100.00%> (+2.21%) ⬆️
app/services/search_service.rb 94.89% <100.00%> (-0.21%) ⬇️
app/controllers/user_tags_controller.rb 83.78% <0.00%> (+1.35%) ⬆️

@daemon1024
Copy link
Member

daemon1024 commented Aug 17, 2021

lelblurred-2021-08-17_23.53.50.mp4

So, the updates work. What we worked out at publiclab/leaflet-blurred-location-display#123

but not publiclab/leaflet-blurred-location-display#133

@daemon1024
Copy link
Member

We will need to reopen publiclab/leaflet-blurred-location-display#133 (comment). I have mentioned my reasoning there. I will work on the fix.

cc @jywarren

@jywarren
Copy link
Member

Ah, ok. Let's merge this and then would you mind trying to debug why publiclab/leaflet-blurred-location-display#133 isn't working? It might involve inserting some console.log statements while running it within plots2, by modifying the code in /public/lib by hand, just to see.

@jywarren jywarren merged commit 4127ee3 into main Aug 17, 2021
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/leaflet-environmental-layers-2.4.5 branch August 17, 2021 18:35
@jywarren
Copy link
Member

Great, and linking to the solution to #133 too: publiclab/leaflet-blurred-location-display#136

reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
Bumps [leaflet-environmental-layers](https://github.com/publiclab/leaflet-environmental-layers) from 2.4.3 to 2.4.5.
- [Release notes](https://github.com/publiclab/leaflet-environmental-layers/releases)
- [Commits](https://github.com/publiclab/leaflet-environmental-layers/commits)

---
updated-dependencies:
- dependency-name: leaflet-environmental-layers
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
Bumps [leaflet-environmental-layers](https://github.com/publiclab/leaflet-environmental-layers) from 2.4.3 to 2.4.5.
- [Release notes](https://github.com/publiclab/leaflet-environmental-layers/releases)
- [Commits](https://github.com/publiclab/leaflet-environmental-layers/commits)

---
updated-dependencies:
- dependency-name: leaflet-environmental-layers
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file JavaScript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants