Fix typo in html tag

[Ishhha]

I fixed the typo in hr tag in line 44 in public/404.html.

fixes #10989

[welcome]

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄


One thing that can help to get started is to make sure you've included a link back to the original issue you're solving, in the format fixes #0000 (for example). And to make sure the PR title describes what you're trying to do! (often it can be the same as the issue title) Thanks! 🙌


Then, you can say hello in our chatroom & share a link to this PR to get a review! 👋 ✅

[gitpod-io]

[github-actions]

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/5987137426/artifacts/206343603

[codecov]

Codecov Report

Merging #10990 (5cac193) into main (9eb56bc) will increase coverage by 0.11%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main   #10990      +/-   ##
==========================================
+ Coverage   82.33%   82.45%   +0.11%     
==========================================
  Files          98       98              
  Lines        5990     5990              
==========================================
+ Hits         4932     4939       +7     
+ Misses       1058     1051       -7     

Impacted Files	Coverage Δ
app/api/srch/search.rb	70.51% <0.00%> (+3.84%)	⬆️
app/services/execute_search.rb	94.44% <0.00%> (+5.55%)	⬆️

[github-actions]

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/5987730166/artifacts/206377779

[kachifako]

Hello @Ishhha , the only change required is that of line 44.
Kindly undo the change in line 74 (remove the semi-colon you added before the equals sign)

Thanks.

[codeclimate]

Code Climate has analyzed commit bac65c7 and detected 0 issues on this pull request.

View more on Code Climate.

[Ishhha]

@kachifako Can u please check it now and give me the feedback?

[github-actions]

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/5989606660/artifacts/206492214

[on2onyekachi]

Hi @Ishhha

was this PR raised as an issue?
If yes, then you should add the issue number to your PR in the description. and It should be in the format fixes #0000 Thanks!

[kachifako]

Thanks @on2onyekachi.

One last correction and you're good @Ishhha. Remove "fixes#10989" from the title.

[on2onyekachi]

@kachifako Yeah, thanks

The self-closing tags with the backslash I thought it's a followed pattern. 'cause I have seen a lot of self-closing tags with backslash probably in some HTML files also in the codebase. will be great to raise them up as an issue too? @TildaDares

[TildaDares]

@on2onyekachi It’s a great idea but it’d be better to do all of the changes in one issue since it’s a really small change.

[Ishhha]

I have corrected the title @kachifako. I think you can merge the PR now. :)

[TildaDares]

Thanks for working on this @Ishhha!!!

[TildaDares]

Thanks for reviewing @on2onyekachi, @kachifako!!

[welcome]

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Do join our weekly check-in to share your this week goal and the awesome work you did 😃. Please find the link to our latest check-in here 📝
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

[TildaDares]

Congratulations @Ishhha 🎉

[Ishhha]

Thank you :)
@TildaDares Can u please suggest some issues in Design a new full-screen user interface for Infragram.org project?

[TildaDares]

Hi @Ishhha, you can take a look at the infragram site and look for issues to work on.

[on2onyekachi]

@on2onyekachi It’s a great idea but it’d be better to do all of the changes in one issue since it’s a really small change.

Okay Thanks @TildaDares . It has been handled by @kachifako

[Ishhha]

Hi @Ishhha, you can take a look at the infragram site and look for issues to work on.

Thank you❤ @TildaDares. I am starting to search and create new issues to work on. :)