Error posting an answer #1938

[sagarpreet-chadha]

Make sure these boxes are checked before your pull request is ready to be reviewed and merged. Thanks!

Solves #1938 .

• all tests pass -- rake test:all
• code is in uniquely-named feature branch, and has been rebased on top of latest master (especially if you've been asked to make additional changes)
• pull request is descriptively named with #number reference back to original issue

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/wiki/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays. Please alert developers on plots-dev@googlegroups.com when your request is ready or if you need assistance.

Thanks!

[PublicLabBot]

	2 Messages
📖	@sagarpreet-chadha Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖	This pull request doesn’t link to a issue number. Please refer to the issue it fixes (if any) in the body of your PR, in the format: Fixes #123.

Generated by 🚫 Danger

[sagarpreet-chadha]

@jywarren , the test for checking error in GET request cannot be made (as mentioned in #1938 comment) because it is the browsers limitation of having limit of around 2000 characters in GET request . The AJAX request of both GET and POST passes during testing for long answers .

source : https://stackoverflow.com/questions/17396510/request-uri-too-large-error-get-rid-of-get?answertab=active#tab-top

[sagarpreet-chadha]

Sir , can you please confirm whether we can make tests to check whether long answers in GET request should show error ? Thank You !

[jywarren]

I think you can in an integration test... depends on if it fully implements the http get spec, I guess. But you'll have to add the test before this change, and let it fail first, to confirm that this change fixes it! Make sense?

[sagarpreet-chadha]

Okay working on it , thanks !

[sagarpreet-chadha]

For GET REQUEST shows error URITooLong: 414 URI Too Long:

When using this line :
response = RestClient.get 'https://publiclab.org/answers/create', {params: {id: node.id , body: VERY VERY LONG TEXT OF APPROX. 3000 WORDS} }

[sagarpreet-chadha]

Maximum length of HTTP GET request :
here : https://stackoverflow.com/questions/2659952/maximum-length-of-http-get-request

[jywarren]

Oh, this looks pretty interesting! What is it? Is it testing via the REST interface? Did it not work? Maybe we should link to documentation for this type of test?

If this isn't necessary for this PR, but is still useful, we could break it into a separate issue -- what do you think?

[jywarren]

Oh, i just saw the REST error output you posted -- that's amazing, and exactly the testable issue we're looking for. Fantastic job on this! This is like the perfect testing catch! :-)))) 👍 💯

[jywarren]

Ah, i understand -- so if we uncomment this test, then we should be able to assert that this line causes an error! I think we want assert_raises:

https://stackoverflow.com/questions/3454925/rails-activesupport-how-to-assert-that-an-error-is-raised#3454953

Make sense? This is great! Do we want to remove the test from below since that doesn't throw the error?

[sagarpreet-chadha]

Great ! @jywarren , assert_raises(Exception) { } does the job . Thank you :)

[jywarren]

Ready to go? :-)

[sagarpreet-chadha]

Yes , can be merged ! :)