Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various pages for tagname and authorname #2108

Merged
merged 3 commits into from
Jan 25, 2018
Merged

Various pages for tagname and authorname #2108

merged 3 commits into from
Jan 25, 2018

Conversation

SidharthBansal
Copy link
Member

@SidharthBansal SidharthBansal commented Jan 25, 2018 •
edited
Loading

Make sure these boxes are checked before your pull request is ready to be reviewed and merged. Thanks!

  • all tests pass -- rake test:all
  • Wiki page with tagname and authorname is functional
  • Map page with tagname and authorname is functional
  • Questions page with tagname and authorname is functional

@SidharthBansal SidharthBansal force-pushed the tag_with_authors branch 4 times, most recently from cb92c7c to 73375f6 Compare January 25, 2018 08:53
@PublicLabBot
Copy link

PublicLabBot commented Jan 25, 2018 •
edited
Loading

1 Warning
⚠️ It looks like you merged from master in this pull request. Please rebase to get rid of the merge commits – you may want to rewind the master branch and rebase instead of merging in from master, which can cause problems when accepting new code!
1 Message
📖 @SidharthBansal Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.

Generated by 🚫 Danger

@jywarren
Copy link
Member

Awesome! Is this ready to merge? Thanks!

@SidharthBansal
Copy link
Member Author

I think, yes. Other changes can be done in other prs as you wrote prs must be modular and should be less than 100 lines of code. Will try to break issues even better from next time.

@jywarren
Copy link
Member

Awesome :-))))) 🎉

@jywarren jywarren merged commit 630357f into publiclab:master Jan 25, 2018
@SidharthBansal SidharthBansal mentioned this pull request Feb 2, 2018
Merged
SrinandanPai pushed a commit to SrinandanPai/plots2 that referenced this pull request May 5, 2019
@SidharthBansal @jywarren
Various pages for tagname and authorname (publiclab#2108)
dcccd18 
* Wiki Route working fine

Fixes publiclab#2084

* Removed Gemfile.lock changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SidharthBansal @PublicLabBot @jywarren