-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show more/less in grids #2184
Show more/less in grids #2184
Conversation
Generated by 🚫 Danger |
Please remove the user validation commits. |
376a38c
to
072f5ba
Compare
@SidharthBansal I have made the required changes as you had asked. The PR is clean, with a single commit from a uniquely-named-feature-branch. Please review the PR. |
@SidharthBansal -- how was this looking, do you think it's something we could move ahead with? Thanks!!! |
There must be changes to this. I think @Ankit-Singla has quit as he has not replied in the other PRS by him from Feb. The other PR's issues were tackled later on by other contributors at public lab. |
Actually, my suggestion is to close this PR and look for other new comers to come and collaborate. If @Ankit-Singla would like to contribute he can reopen the PR. |
That's fair -- we'd love your help @Ankit-Singla -- thanks! We're going to close this for now but please reach out if you're able to take it back up. It looks very promising, though! Thanks again! |
Fixes #2150
Make sure these boxes are checked before your pull request is ready to be reviewed and merged. Thanks!
rake test:all
Please be sure you've reviewed our contribution guidelines at https://publiclab.org/wiki/contributing-to-public-lab-software
We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays. Please alert developers on plots-dev@googlegroups.com when your request is ready or if you need assistance.
Thanks!