Maps and Question Tests for show_for_author

[SidharthBansal]

These are the maps and question tests for show_for_author various routes wrt #2084.
I have rearranged the show_for_author method so that it will be analogous to show method of the controller.

[PublicLabBot]

	12 Errors
🚫	There was a test error at: Failure: test_search_results_page_at_/search/foo(Minitest::Result) [/app/app/views/notes/notes.html.erb:23]: ActionView::Template::Error: undefined method title' for nil:NilClass app/views/notes/_notes.html.erb:23:in block in _app_views_notes__notes_html_erb__3925696063156259587_54536340’ app/views/notes/_notes.html.erb:4:in _app_views_notes__notes_html_erb___3925696063156259587_54536340' app/views/searches/results.html.erb:13:in _app_views_searches_results_html_erb__2821168036676309137_52562360’ test/functional/searches_controller_test.rb:13:in `block in '
🚫	There was a test error at: Failure: test_admins_and_moderators_view_redirect-tagged_notes_with_flash_warning(Minitest::Result) [/app/app/views/sidebar/wikis.html.erb:11]: ActionView::Template::Error: undefined method title' for nil:NilClass app/views/sidebar/_wikis.html.erb:11:in block in _app_views_sidebar__wikis_html_erb_2259186177673164262_68256400’ app/views/sidebar/_wikis.html.erb:6:in _app_views_sidebar__wikis_html_erb___2259186177673164262_68256400' app/views/sidebar/_related.html.erb:69:in _app_views_sidebar__related_html_erb__420097327060383026_39192520’ app/views/notes/show.html.erb:3:in _app_views_notes_show_html_erb___407190295984885113_75245920' <a href='https://github.com/SidharthBansal/plots2/tree/map_and_question_test/test/functional/notes_controller_test.rb#L104'>test/functional/notes_controller_test.rb:104</a>:in block in '
🚫	There was a test error at: Failure: test_should_display_an_icon_for_users_with_streak_longer_than_7days(Minitest::Result) [/app/app/views/sidebar/_wikis.html.erb:11]: ActionView::Template::Error: undefined method title' for nil:NilClass app/views/sidebar/_wikis.html.erb:11:in block in _app_views_sidebar__wikis_html_erb_2259186177673164262_68256400’ app/views/sidebar/_wikis.html.erb:6:in _app_views_sidebar__wikis_html_erb___2259186177673164262_68256400' app/views/sidebar/_related.html.erb:69:in _app_views_sidebar__related_html_erb__420097327060383026_39192520’ app/views/notes/show.html.erb:3:in _app_views_notes_show_html_erb___407190295984885113_75245920' <a href='https://github.com/SidharthBansal/plots2/tree/map_and_question_test/test/functional/notes_controller_test.rb#L405'>test/functional/notes_controller_test.rb:405</a>:in block in '
🚫	There was a test error at: Failure: test_should_list_only_research_notes_with_status_1in_liked(Minitest::Result) [/app/app/views/sidebar/_wikis.html.erb:11]: ActionView::Template::Error: undefined method title' for nil:NilClass app/views/sidebar/_wikis.html.erb:11:in block in _app_views_sidebar__wikis_html_erb_2259186177673164262_68256400’ app/views/sidebar/_wikis.html.erb:6:in _app_views_sidebar__wikis_html_erb___2259186177673164262_68256400' app/views/sidebar/_user.html.erb:22:in _app_views_sidebar__user_html_erb__554916110896017614_60843560’ app/views/notes/index.html.erb:6:in _app_views_notes_index_html_erb__632575255735267416_61492900' app/controllers/notes_controller.rb:284:in liked’ test/functional/notes_controller_test.rb:549:in `block in '
🚫	There was a test error at: Failure: test_should_list_only_research_notes_with_status_1in_popular(Minitest::Result) [/app/app/views/sidebar/_wikis.html.erb:11]: ActionView::Template::Error: undefined method title' for nil:NilClass app/views/sidebar/_wikis.html.erb:11:in block in _app_views_sidebar__wikis_html_erb_2259186177673164262_68256400’ app/views/sidebar/_wikis.html.erb:6:in _app_views_sidebar__wikis_html_erb___2259186177673164262_68256400' app/views/sidebar/_user.html.erb:22:in _app_views_sidebar__user_html_erb__554916110896017614_60843560’ app/views/notes/index.html.erb:6:in _app_views_notes_index_html_erb__632575255735267416_61492900' app/controllers/notes_controller.rb:298:in popular’ test/functional/notes_controller_test.rb:539:in `block in '
🚫	There was a test error at: Failure: test_should_load_iframe_url_in_comments(Minitest::Result) [/app/app/views/sidebar/wikis.html.erb:11]: ActionView::Template::Error: undefined method title' for nil:NilClass app/views/sidebar/_wikis.html.erb:11:in block in _app_views_sidebar__wikis_html_erb_2259186177673164262_68256400’ app/views/sidebar/_wikis.html.erb:6:in _app_views_sidebar__wikis_html_erb___2259186177673164262_68256400' app/views/sidebar/_related.html.erb:69:in _app_views_sidebar__related_html_erb__420097327060383026_39192520’ app/views/notes/show.html.erb:3:in _app_views_notes_show_html_erb___407190295984885113_75245920' <a href='https://github.com/SidharthBansal/plots2/tree/map_and_question_test/test/functional/notes_controller_test.rb#L385'>test/functional/notes_controller_test.rb:385</a>:in block in '
🚫	There was a test error at: Failure: test_show_note_by_id(Minitest::Result) [/app/app/views/sidebar/wikis.html.erb:11]: ActionView::Template::Error: undefined method title' for nil:NilClass app/views/sidebar/_wikis.html.erb:11:in block in _app_views_sidebar__wikis_html_erb_2259186177673164262_68256400’ app/views/sidebar/_wikis.html.erb:6:in _app_views_sidebar__wikis_html_erb___2259186177673164262_68256400' app/views/sidebar/_related.html.erb:69:in _app_views_sidebar__related_html_erb__420097327060383026_39192520’ app/views/notes/show.html.erb:3:in _app_views_notes_show_html_erb___407190295984885113_75245920' <a href='https://github.com/SidharthBansal/plots2/tree/map_and_question_test/test/functional/notes_controller_test.rb#L25'>test/functional/notes_controller_test.rb:25</a>:in block in '
🚫	There was a test error at: Failure: test_show_note_with_Browse_other_activities_link(Minitest::Result) [/app/app/views/sidebar/wikis.html.erb:11]: ActionView::Template::Error: undefined method title' for nil:NilClass app/views/sidebar/_wikis.html.erb:11:in block in _app_views_sidebar__wikis_html_erb_2259186177673164262_68256400’ app/views/sidebar/_wikis.html.erb:6:in _app_views_sidebar__wikis_html_erb___2259186177673164262_68256400' app/views/sidebar/_related.html.erb:69:in _app_views_sidebar__related_html_erb__420097327060383026_39192520’ app/views/notes/show.html.erb:3:in _app_views_notes_show_html_erb___407190295984885113_75245920' <a href='https://github.com/SidharthBansal/plots2/tree/map_and_question_test/test/functional/notes_controller_test.rb#L120'>test/functional/notes_controller_test.rb:120</a>:in block in '
🚫	There was a test error at: Failure: test_should_choose_i18n_for_layout/alerts(Minitest::Result) [/app/app/views/dashboard/_node_wiki.html.erb:6]: ActionView::Template::Error: undefined method author' for nil:NilClass app/views/dashboard/_node_wiki.html.erb:6:in _app_views_dashboard__node_wiki_html_erb__4433760258483973810_72125760’ app/views/dashboard/_activity.html.erb:67:in block in _app_views_dashboard__activity_html_erb__1785387033566173153_78157820' app/views/dashboard/_activity.html.erb:65:in each’ app/views/dashboard/_activity.html.erb:65:in each_with_index' app/views/dashboard/_activity.html.erb:65:in _app_views_dashboard__activity_html_erb__1785387033566173153_78157820’ app/views/dashboard/dashboard.html.erb:45:in _app_views_dashboard_dashboard_html_erb__698359242826034683_59005360' app/controllers/home_controller.rb:55:in dashboard’ test/functional/home_controller_test.rb:74:in block (2 levels) in <class:HomeControllerTest>' test/functional/home_controller_test.rb:64:in each’ test/functional/home_controller_test.rb:64:in `block in '
🚫	There was a test error at: Failure: test_should_get_dashboard(Minitest::Result) [/app/app/views/dashboard/_node_wiki.html.erb:6]: ActionView::Template::Error: undefined method author' for nil:NilClass app/views/dashboard/_node_wiki.html.erb:6:in _app_views_dashboard__node_wiki_html_erb__4433760258483973810_72125760’ app/views/dashboard/_activity.html.erb:67:in block in _app_views_dashboard__activity_html_erb__1785387033566173153_78157820' app/views/dashboard/_activity.html.erb:65:in each’ app/views/dashboard/_activity.html.erb:65:in each_with_index' app/views/dashboard/_activity.html.erb:65:in _app_views_dashboard__activity_html_erb__1785387033566173153_78157820’ app/views/dashboard/dashboard.html.erb:45:in _app_views_dashboard_dashboard_html_erb__698359242826034683_59005360' app/controllers/home_controller.rb:55:in dashboard’ test/functional/home_controller_test.rb:28:in `block in '
🚫	There was a test error at: Failure: test_should_get_dashboard_if_not_logged_in(Minitest::Result) [/app/app/views/dashboard/_node_wiki.html.erb:6]: ActionView::Template::Error: undefined method author' for nil:NilClass app/views/dashboard/_node_wiki.html.erb:6:in _app_views_dashboard__node_wiki_html_erb__4433760258483973810_72125760’ app/views/dashboard/_activity.html.erb:67:in block in _app_views_dashboard__activity_html_erb__1785387033566173153_78157820' app/views/dashboard/_activity.html.erb:65:in each’ app/views/dashboard/_activity.html.erb:65:in each_with_index' app/views/dashboard/_activity.html.erb:65:in _app_views_dashboard__activity_html_erb__1785387033566173153_78157820’ app/views/dashboard/dashboard.html.erb:45:in _app_views_dashboard_dashboard_html_erb__698359242826034683_59005360' app/controllers/home_controller.rb:55:in dashboard’ test/functional/home_controller_test.rb:20:in `block in '
🚫	There was a test error at: Failure: test_should_show_only_unmoderated_spam(Minitest::Result) [/app/app/views/dashboard/_node_wiki.html.erb:6]: ActionView::Template::Error: undefined method author' for nil:NilClass app/views/dashboard/_node_wiki.html.erb:6:in _app_views_dashboard__node_wiki_html_erb__4433760258483973810_72125760’ app/views/dashboard/_activity.html.erb:67:in block in _app_views_dashboard__activity_html_erb__1785387033566173153_78157820' app/views/dashboard/_activity.html.erb:65:in each’ app/views/dashboard/_activity.html.erb:65:in each_with_index' app/views/dashboard/_activity.html.erb:65:in _app_views_dashboard__activity_html_erb__1785387033566173153_78157820’ app/views/dashboard/dashboard.html.erb:45:in _app_views_dashboard_dashboard_html_erb__698359242826034683_59005360' app/controllers/home_controller.rb:55:in dashboard’ test/functional/home_controller_test.rb:40:in `block in '

	1 Warning
⚠️	It looks like you merged from master in this pull request. Please rebase to get rid of the merge commits – you may want to rewind the master branch and rebase instead of merging in from master, which can cause problems when accepting new code!

	1 Message
📖	@SidharthBansal Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.

Generated by 🚫 Danger

[SidharthBansal]

@jywarren I am closing this one because in this branch I am getting some errors related to #2172 which are disturbing the other tests which I am writing. Please review #2207