Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty Search Validation ( Fixes #2181 ) #2190

Closed
wants to merge 1 commit into from

Conversation

Ankit-Singla
Copy link

@Ankit-Singla Ankit-Singla commented Feb 1, 2018

Make sure these boxes are checked before your pull request is ready to be reviewed and merged. Thanks!

  • all tests pass -- rake test:all
  • code is in uniquely-named feature branch, and has been rebased on top of latest master (especially if you've been asked to make additional changes)
  • pull request is descriptively named with #number reference back to original issue

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/wiki/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays. Please alert developers on plots-dev@googlegroups.com when your request is ready or if you need assistance.

Thanks!

@PublicLabBot
Copy link

3 Messages
📖 @Ankit-Singla Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖 This pull request doesn’t link to a issue number. Please refer to the issue it fixes (if any) in the body of your PR, in the format: Fixes #123.
📖 It looks like you haven’t marked all the checkboxes. Help us review and accept your suggested changes by going through the steps one by one. If it is still a ‘Work in progresss’, please include ‘[WIP]’ in the title.

Generated by 🚫 Danger

@Ankit-Singla
Copy link
Author

@namangupta01 Please review this pull request.

@namangupta01
Copy link
Member

@Ankit-Singla Please don't open pr for the issue which already has a pr. There is no good in doing same thing multiple time. Instead of that you can focus on issue which doesn't have pr. :)

@namangupta01
Copy link
Member

Closing since issue already have a pr #2182

@Ankit-Singla
Copy link
Author

Ankit-Singla commented Feb 1, 2018

@namangupta01 Sorry, I thought no one was working on it since no one claimed the issue and the issue wasn't assigned to anyone.
Regarding the PR, I opened another one because checks failed in your PR #2182 .

@namangupta01
Copy link
Member

@Ankit-Singla No issues! There are plenty of fto-candidate issue if you want you can work on them since i think you are new to the codebase. Just comment there to claim the issue and to check if somebody is working on that or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants