-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix post views in small screens #2419
Conversation
Generated by 🚫 Danger |
And thank you for your contribution!!! 👍 |
4464562
to
9a1bfe6
Compare
PR related to issue #2397 Removed gemfile.lock. Will post the screenshot. |
Hi, @Nimmyjv -- this looks great, and I think no screenshot needed as it's pretty simple. But I did want to ask - do you think it's possible to, using JavaScript, make the extra information visible only when you click a <a class="hidden-lg hidden-md" href="javscript:$('node-extras').toggleClass('hidden-xs hidden-sm');">
<i class="fa fa-ellipsis-h"></i>
</a> This would show the extras 'button' only on small screens, and that button (if I wrote the code right... it might take some testing out) should toggle the hiding of the extras. We'd also have to add 'node-extras' as a class on this line: <span class="hidden-xs hidden-sm hidden-print"> What do you think of this? See how it might work? Also i don't know if you were able to try this out but you can test it by just narrowing and widening the browser window. Much easier than using a phone! |
Hi @Nimmyjv ,do you need any help? We are here to help. |
Sorry for the late reply..Will try out that with js. |
No issue @Nimmyjv , please let us know if you need any help.Thanks !!! |
Hi, just checking if you've gotten stuck on this at all, or if I could help in any way? Thanks! |
As the person is inactive for more than a month, I am closing the PR. In case you want to push changes please feel free to open a new PR. |
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
fixes #0000
-style reference to original issue #@publiclab/reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.
Thanks!