Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix post views in small screens #2419

Closed
wants to merge 1 commit into from

Conversation

Nimmyjv
Copy link

@Nimmyjv Nimmyjv commented Feb 28, 2018

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • PR body includes fixes #0000-style reference to original issue #
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.

Thanks!

@PublicLabBot
Copy link

PublicLabBot commented Feb 28, 2018

2 Messages
📖 @Nimmyjv Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖 It looks like you haven’t marked all the checkboxes. Help us review and accept your suggested changes by going through the steps one by one. If it is still a ‘Work in progresss’, please include ‘[WIP]’ in the title.

Generated by 🚫 Danger

@Souravirus
Copy link
Member

@Nimmyjv is this PR related to #2397? Also it would be great if you post a screenshot of the webpage. And please remove the Gemfile.lock from the PR

@jywarren
Copy link
Member

jywarren commented Mar 2, 2018

And thank you for your contribution!!! 👍

@Nimmyjv
Copy link
Author

Nimmyjv commented Mar 2, 2018

PR related to issue #2397 Removed gemfile.lock. Will post the screenshot.

@jywarren
Copy link
Member

jywarren commented Mar 3, 2018

Hi, @Nimmyjv -- this looks great, and I think no screenshot needed as it's pretty simple. But I did want to ask - do you think it's possible to, using JavaScript, make the extra information visible only when you click a ... button? This could be done with, say (i think this'd work):

<a class="hidden-lg hidden-md" href="javscript:$('node-extras').toggleClass('hidden-xs hidden-sm');">
  <i class="fa fa-ellipsis-h"></i>
</a>

This would show the extras 'button' only on small screens, and that button (if I wrote the code right... it might take some testing out) should toggle the hiding of the extras.

We'd also have to add 'node-extras' as a class on this line:

<span class="hidden-xs hidden-sm hidden-print">

What do you think of this? See how it might work?

Also i don't know if you were able to try this out but you can test it by just narrowing and widening the browser window. Much easier than using a phone!

@SidharthBansal
Copy link
Member

Hi @Nimmyjv ,do you need any help? We are here to help.

@Nimmyjv
Copy link
Author

Nimmyjv commented Mar 21, 2018

Sorry for the late reply..Will try out that with js.

@grvsachdeva
Copy link
Member

No issue @Nimmyjv , please let us know if you need any help.Thanks !!!

@jywarren
Copy link
Member

Hi, just checking if you've gotten stuck on this at all, or if I could help in any way? Thanks!

@SidharthBansal
Copy link
Member

As the person is inactive for more than a month, I am closing the PR. In case you want to push changes please feel free to open a new PR.
Thanks for contributing at Public Lab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants