-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Place tag detection and replacing "-" with "" #2734
Merged
jywarren
merged 19 commits into
publiclab:master
from
mridulnagpal:location-tag-geocoder
Jun 5, 2018
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
80c3e44
Place tag detection and replacing "-" with ""
mridulnagpal 1a30611
Javascript changed
mridulnagpal 2dc5cfe
Geocode method added
mridulnagpal 4660cc4
Tweaks
mridulnagpal 6be9dbc
Tweaks
mridulnagpal 2e3eeb6
Tweaks
mridulnagpal 690027c
Tweaks 2
mridulnagpal dddb402
Tweaks 3
mridulnagpal d6e18c7
Update Gemfile.lock
mridulnagpal 3dfc1ef
Climate fix
mridulnagpal 48435fa
Merge branch 'location-tag-geocoder' of https://github.com/mridulnagp…
mridulnagpal cbf8132
add geocoded tags
mridulnagpal 9cc2c0c
Tweaks
mridulnagpal c5ba0ab
Merge branch 'master' of https://github.com/publiclab/plots2 into loc…
mridulnagpal c13dd2c
Block shift and callback to onComplete
mridulnagpal abc8b5e
onComplete binded with ajax
mridulnagpal 719b598
place in starting of tag detection
mridulnagpal 6f0bd4c
Tweaks
mridulnagpal 794fa11
Merge branch 'master' of https://github.com/publiclab/plots2 into loc…
mridulnagpal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, so I think we can put off refactoring
addTag
for now -- or do it in an independent PR. This should just submit the HTML form. I'm going to merge it!