-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added OAuth hash for testing Github provider #2874
Added OAuth hash for testing Github provider #2874
Conversation
Generated by 🚫 Danger |
@jywarren can you please review the changes? This is ready. |
I think let's try to get this all wrapped up and debugged. I'll make time early this week to go through the setup steps for the additional OAuth systems. In the meantime if you have nothing on your hands, perhaps you could tackle some smaller issues, like tests, codeClimate, things like that? I'd really appreciate it. Perhaps especially the persistent issue we're seeing with tests not completing properly and needing to be restarted? #2824 i think... Merging this! Very exciting! |
OK, then we will move to Bootstrap once we are completely done with OAuth. I have found MANY bugs at publiclab.org. Will you mind if I will create issues for all of them? |
I am right now working on tests for Github Provider |
I think if you have a very big list, you could start with a kind of
planning issue from which you gradually break out new issues. That way it
doesn't flood the issue tracker all at once?
Great, thank you!!!!
…On Mon, Jun 25, 2018 at 6:19 PM Sidharth Bansal ***@***.***> wrote:
I am right now working on tests for Github Provider
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#2874 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJwBkHel40MVpI2cjjswVds7xm17Yks5uAWHlgaJpZM4UwAzP>
.
|
Do we need still RuboCop Continuous Integration as listed in #2814 (comment)? If yes, I am happy to work on this too. I will create an issue for this one. |
OR were you referring to do the rubocop changes? |
I think the idea was to see if we can get Rubocop to offer to automatically
fix formatting for us. @siaw23 has mentioned this is possible. Let's open
an issue and collect information?
…On Mon, Jun 25, 2018 at 6:52 PM Sidharth Bansal ***@***.***> wrote:
OR were you referring to do the rubocop changes?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#2874 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ9e014ov5nO6Uel6A9t3gAWn1fCOks5uAWl7gaJpZM4UwAzP>
.
|
Opening a new issue |
I have created auth hash for testing of Github provider. This is part of #2676 issue's Github provider subissue