Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added OAuth hash for testing Github provider #2874

Merged
merged 2 commits into from
Jun 25, 2018

Conversation

SidharthBansal
Copy link
Member

@SidharthBansal SidharthBansal commented Jun 20, 2018

I have created auth hash for testing of Github provider. This is part of #2676 issue's Github provider subissue

@ghost ghost assigned SidharthBansal Jun 20, 2018
@ghost ghost added the in progress label Jun 20, 2018
@plotsbot
Copy link
Collaborator

plotsbot commented Jun 20, 2018

1 Warning
⚠️ It looks like you merged from master in this pull request. Please rebase to get rid of the merge commits – you may want to rewind the master branch and rebase instead of merging in from master, which can cause problems when accepting new code!
1 Message
📖 @SidharthBansal Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.

Generated by 🚫 Danger

@SidharthBansal
Copy link
Member Author

@jywarren can you please review the changes? This is ready.
@jywarren I want to know whether I should start working on Bootstrap Upgrade along with the OAuth OR shall I wait until we are done with OAUTH.
I am eager to learn more about bootstrap but managing both projects simultaneously may be difficult.
I will do whatsoever seems best to you.
Thanks

@jywarren
Copy link
Member

I think let's try to get this all wrapped up and debugged. I'll make time early this week to go through the setup steps for the additional OAuth systems. In the meantime if you have nothing on your hands, perhaps you could tackle some smaller issues, like tests, codeClimate, things like that? I'd really appreciate it.

Perhaps especially the persistent issue we're seeing with tests not completing properly and needing to be restarted? #2824 i think...

Merging this! Very exciting!

@jywarren jywarren merged commit bbe3cdc into publiclab:master Jun 25, 2018
@ghost ghost removed the ready label Jun 25, 2018
@SidharthBansal
Copy link
Member Author

OK, then we will move to Bootstrap once we are completely done with OAuth. I have found MANY bugs at publiclab.org. Will you mind if I will create issues for all of them?
I will send patches to some of the issues as well.
I will see the Travis for sure. I want to work on Account Deletion feature. It fascinated me a lot.

@SidharthBansal
Copy link
Member Author

I am right now working on tests for Github Provider

@jywarren
Copy link
Member

jywarren commented Jun 25, 2018 via email

@SidharthBansal
Copy link
Member Author

SidharthBansal commented Jun 25, 2018

Do we need still RuboCop Continuous Integration as listed in #2814 (comment)? If yes, I am happy to work on this too. I will create an issue for this one.

@SidharthBansal
Copy link
Member Author

OR were you referring to do the rubocop changes?

@jywarren
Copy link
Member

jywarren commented Jun 25, 2018 via email

@SidharthBansal
Copy link
Member Author

Opening a new issue
Thanks

SrinandanPai pushed a commit to SrinandanPai/plots2 that referenced this pull request May 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants