-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User Session Controller tests for Facebook #2966
Merged
jywarren
merged 2 commits into
publiclab:master
from
SidharthBansal:user_session_fb_tests
Jul 2, 2018
Merged
User Session Controller tests for Facebook #2966
jywarren
merged 2 commits into
publiclab:master
from
SidharthBansal:user_session_fb_tests
Jul 2, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
SidharthBansal
force-pushed
the
user_session_fb_tests
branch
from
July 2, 2018 11:29
03e2158
to
6358de9
Compare
This is ready to be merged |
ghost
removed
the
ready
label
Jul 2, 2018
👍 Awesome! |
This way too quick |
lol i know, i just happened to look when i saw your PR updated "17 seconds
ago"... haha
…On Mon, Jul 2, 2018 at 5:11 PM Sidharth Bansal ***@***.***> wrote:
This way too quick
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#2966 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ-ZGJsLyiIONQH3zZPDec8212f2gks5uCoxpgaJpZM4U-c2y>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
fixes #0000
-style reference to original issue #@publiclab/reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.
Thanks!