Tests for not displaying uid(WIP)

[SidharthBansal]

Closes #2676

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
• code is in uniquely-named feature branch and has no merge conflicts
• PR is descriptively titled
• PR body includes fixes #0000-style reference to original issue #
• ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.

Thanks!

[SidharthBansal]

This is under progress.
@jywarren I am having fever. So cant focus much. Sorrry for the delay in prs. I will try to send prs as soon as I can.

[plotsbot]

	4 Errors
🚫	There was a test failure at: Failure: test_Oauth_tags_are_in_form_of_oauth:provider_for_facebook(Minitest::Result) [/app/test/functional/users_controller_test.rb:310]: Expected at least 1 element matching “div#tag_17”, found 0.. Expected 0 to be >= 1.
🚫	There was a test failure at: Failure: test_Oauth_tags_are_in_form_of_oauth:provider_for_github(Minitest::Result) [/app/test/functional/users_controller_test.rb:271]: Expected at least 1 element matching “span#tag_18”, found 0.. Expected 0 to be >= 1.
🚫	There was a test failure at: Failure: test_Oauth_tags_are_in_form_of_oauth:provider_for_google(Minitest::Result) [/app/test/functional/users_controller_test.rb:297]: Expected at least 1 element matching “span#tag_19”, found 0.. Expected 0 to be >= 1.
🚫	There was a test failure at: Failure: test_Oauth_tags_are_in_form_of_oauth:provider_for_twitter(Minitest::Result) [/app/test/functional/users_controller_test.rb:284]: Expected at least 1 element matching “span#tag_20”, found 0.. Expected 0 to be >= 1.

	2 Messages
📖	@SidharthBansal Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖	It looks like you haven’t marked all the checkboxes. Help us review and accept your suggested changes by going through the steps one by one. If it is still a ‘Work in progresss’, please include ‘[WIP]’ in the title.

Generated by 🚫 Danger

[SidharthBansal]

@jywarren can you please tell me the what I am doing wrong here. I checked in the view it is

plots2/app/views/tag/_tags.html.erb

Lines 20 to 25 in de4d09f

	<li><span id="tag_<%= tag.id %>" class="label <%= label_name %>" style="cursor:pointer" data-toggle="popover" data-trigger="manual" data-count=0 data-placement="top" data-content="<a href='/contributors/<%= tag.name %>'><%= Tag.tagged_node_count(tag.name) || 0 %> notes - <%= Tag.contributors(tag.name).count %> people <br></a>" data-html="true" title="<%= tag.name %>">
	<% if tag.name[0..4] != "oauth" %>
	<%= tag.name %>
	<% else %>
	<%= tag.name[0..5] + tag.name.split(':')[1] %>
	<% end %>

It says span with id as tag_+tag.id. Is tag.id not same as usertag.id?

[jywarren]

Hmm, can you check it locally? Maybe also look for the total count of items like span.label to be sure they're appearing at all?

[SidharthBansal]

Yeah I am trying to debug this. I am trying my level best to write these test asap. It is giving errors.

On localhost everything is working fine. Also in production things are working fine. Just trying to debug the tests.

[jywarren]

ok, no worries, and thanks for your hard work! Maybe @publiclab/reviewers could help if you can't figure it out?

…

On Sat, Aug 4, 2018 at 12:32 PM Sidharth Bansal ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In test/functional/users_controller_test.rb <#3139 (comment)>: > @@ -257,4 +257,57 @@ def setup post :test_digest_email assert_redirected_to '/' end + + test 'Oauth tags are in form of oauth:provider for github' do + UserSession.create(users(:jeff)) + user = users(:jeff) + auth = { "provider" => "github", "uid" => "123456789"} + uid = user.id + identity = UserTag.create_with_omniauth(auth, uid) + get :profile + assert_response :redirect + assert_redirected_to '/profile/jeff' + s = "span#tag_"+identity.id.to_s + assert_select s,'omniauth:github' Yeah I am trying to debug this. I am trying my level best to write these test asap. It is giving errors. On localhost everything is working fine. Also in production things are working fine. Just trying to debug the tests. — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#3139 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJ-ZZ0vTz69W4Blo-hsaJ7dCFlLmeks5uNcx9gaJpZM4VdEe1> .

[SidharthBansal]

I am closing this and turning these tests into gci help wanted issues.
Thanks

[SidharthBansal]

The system has changed considerably from the time I pushed these changes. So there is a need to close this one.
Thanks