Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update config.yml #3415

Merged
merged 1 commit into from
Sep 24, 2018
Merged

Update config.yml #3415

merged 1 commit into from
Sep 24, 2018

Conversation

wilsantow
Copy link
Contributor

@wilsantow wilsantow commented Sep 24, 2018

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • PR body includes fixes #0000-style reference to original issue #
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.

Thanks!

@welcome
Copy link

welcome bot commented Sep 24, 2018

Thanks for opening this pull request! Dangerbot will test out your code and reply in a bit with some pointers and requests. There may be some errors, but don't worry! We're here to help! 👍🎉😄

@plotsbot
Copy link
Collaborator

3 Messages
📖 @wilsantow Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖 Your pull request is on the master branch. Please make a separate feature branch) with a descriptive name like new-blog-design while making PRs in the future.
📖 It looks like you haven’t marked all the checkboxes. Help us review and accept your suggested changes by going through the steps one by one. If it is still a ‘Work in progresss’, please include ‘[WIP]’ in the title.

Generated by 🚫 Danger

@wilsantow
Copy link
Contributor Author

marked all the checkboxes

@grvsachdeva
Copy link
Member

Hi @wilsantow, could you please tag the issue, this PR is solving. Thanks!

@jywarren jywarren merged commit 8ab6368 into publiclab:master Sep 24, 2018
@jywarren jywarren mentioned this pull request Sep 24, 2018
5 tasks
@jywarren
Copy link
Member

Hi -- this looks perfect; merging now. If you're looking for a new challenge, please take a look at our help-wanted list: https://github.com/publiclab/plots2/labels/help-wanted

Thanks!

SrinandanPai pushed a commit to SrinandanPai/plots2 that referenced this pull request May 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants