-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Number of views and comments on small screens #3795
Conversation
|
Generated by 🚫 Danger |
@thesparks great work thanks for contribute, 🎊 😃 |
@thesparks I think it should be visible, without click on small screen(ex. mobile). |
@jywarren @Souravirus @SidharthBansal what do you think about this? |
@avsingh999, nooooo, I spent so much time on it(((( |
@thesparks Sorry, I didn't see that comment. |
@thesparks your work is great ,we realy love it, keep contributing 😃 |
@thesparks one more thing please check this is on moblie view in your browser, it's working fine or not |
@avsingh999, 👌 |
@jywarren @Souravirus @SidharthBansal It looks good to me, |
@thesparks I just had one problem with this implementation. The thing is that after you press the '...' button, the screen becomes kind of shaky. So, can you represent the information in two lines? It would be quite good from the user point of view. Thanks for your hard work !! |
@Souravirus, please check it yourself, i cant run plots2 (troubles with phantomjs when yarn install). |
@jywarren, Done. |
@Souravirus, this trouble only at GIF, in real app - |
@thesparks then that's great. Let @jywarren see this and after that, it is good to merge. Thanks!! |
Awesome!!! |
* Update show.html.erb * collapse-btn style
Fixes #2397
rake test
@publiclab/reviewers
for help, in a comment below