-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed list and grid view for smaller screens #4201
Removed list and grid view for smaller screens #4201
Conversation
Generated by 🚫 Danger |
@oorjitchowdhary this same error is across many other web pages. Can you find them and create issues for them? |
Okay sure.. I'll look for them.. |
This comment has been minimized.
This comment has been minimized.
@jywarren merging this one. Hope you will like it. |
@SidharthBansal The buttons are used on Desktop view for /questions Mobile view for /questions Desktop view for /notes Mobile view for /notes So we don't need to create any issues.. |
It's great that we don't have these types of errors anymore.
Thanks for your help
…On Sun, Dec 9, 2018 at 3:15 PM Oorjit Chowdhary ***@***.***> wrote:
@SidharthBansal <https://github.com/SidharthBansal> The buttons are used
on /tags, /questions and /notes..
But they don't have any error now as I have fixed the error in the partial
template..
Here are the views for them..
Desktop view for /questions
[image: screenshot 71]
<https://user-images.githubusercontent.com/39333058/49695697-07a23480-fbc5-11e8-9c5a-63969fdb39c6.png>
Mobile view for /questions
[image: screenshot 72]
<https://user-images.githubusercontent.com/39333058/49695698-07a23480-fbc5-11e8-83c0-ddc1398d81a2.png>
Desktop view for /notes
[image: screenshot 73]
<https://user-images.githubusercontent.com/39333058/49695699-07a23480-fbc5-11e8-91a7-8b6bc6dead9b.png>
Mobile view for /notes
[image: screenshot 74]
<https://user-images.githubusercontent.com/39333058/49695700-083acb00-fbc5-11e8-8e37-e8470cdf7604.png>
So we don't need to create any issues..
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4201 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AUACQ3QP3B2EyS_fTNhlDvaT_sjggaP3ks5u3NvBgaJpZM4ZJ-jJ>
.
|
@SidharthBansal Please create a task for this on gci.. Thanks a lot |
I hope #3733 is present on the GCI. Please claim it. If it is not present. Inform me. |
It isn't present .. Just searched.. Sorry to bother you so much.. |
Btw how do you search? I have never used the gci student's dashboard. It can be really tough to search at many times. Right? |
There is a search bar |
Please check the comment |
Fixes #3733
@publiclab/reviewers Please check this out.. Thanks
Desktop view
Mobile view
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!