Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed list and grid view for smaller screens #4201

Merged
merged 1 commit into from
Dec 9, 2018
Merged

Removed list and grid view for smaller screens #4201

merged 1 commit into from
Dec 9, 2018

Conversation

oorjitchowdhary
Copy link
Member

@oorjitchowdhary oorjitchowdhary commented Dec 9, 2018

Fixes #3733
@publiclab/reviewers Please check this out.. Thanks

Desktop view

screenshot 68

Mobile view

screenshot 69

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@plotsbot
Copy link
Collaborator

plotsbot commented Dec 9, 2018

2 Messages
📖 @oorjitchowdhary Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖 It looks like you haven’t marked all the checkboxes. Help us review and accept your suggested changes by going through the steps one by one. If it is still a ‘Work in progresss’, please include ‘[WIP]’ in the title.

Generated by 🚫 Danger

@SidharthBansal
Copy link
Member

@oorjitchowdhary this same error is across many other web pages. Can you find them and create issues for them?
We can then have your work. Also, we will be able to create GCI tasks for that.

@oorjitchowdhary
Copy link
Member Author

Okay sure.. I'll look for them..

@SidharthBansal

This comment has been minimized.

@SidharthBansal
Copy link
Member

@jywarren merging this one. Hope you will like it.

@SidharthBansal SidharthBansal merged commit a833569 into publiclab:master Dec 9, 2018
@oorjitchowdhary
Copy link
Member Author

@SidharthBansal The buttons are used on /tags, /questions and /notes..
But they don't have any error now as I have fixed the error in the partial template..
Here are the views for them..

Desktop view for /questions

screenshot 71

Mobile view for /questions

screenshot 72

Desktop view for /notes

screenshot 73

Mobile view for /notes

screenshot 74

So we don't need to create any issues..

@SidharthBansal
Copy link
Member

SidharthBansal commented Dec 9, 2018 via email

@oorjitchowdhary
Copy link
Member Author

@SidharthBansal Please create a task for this on gci.. Thanks a lot

@SidharthBansal
Copy link
Member

I hope #3733 is present on the GCI. Please claim it. If it is not present. Inform me.

@oorjitchowdhary
Copy link
Member Author

It isn't present .. Just searched.. Sorry to bother you so much..

@SidharthBansal
Copy link
Member

Btw how do you search? I have never used the gci student's dashboard. It can be really tough to search at many times. Right?

@oorjitchowdhary
Copy link
Member Author

There is a search bar

@SidharthBansal
Copy link
Member

Please check the comment
#3733 (comment)
It means I have published it

@oorjitchowdhary
Copy link
Member Author

image

Something's wrong

SrinandanPai pushed a commit to SrinandanPai/plots2 that referenced this pull request May 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants