Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added unit test for Tag.related method #5129

Merged
merged 2 commits into from
Mar 18, 2019

Conversation

Nirvikalpa108
Copy link
Contributor

Fixes #3480

Hi @jywarren thanks for all your help in getting me started with this codebase. I couldn't run the tests locally. I just get an error saying my Ruby version is not the same as that mentioned in Gemfile. I have some outstanding installation questions which I've asked in an issue for first-timers installing. Hopefully I'll get that sorted soon! Otherwise, let me know if I've done this PR correctly? Thank you so much!! 😃

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

@welcome
Copy link

welcome bot commented Mar 17, 2019

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄
Also, can you tell us your Twitter handle so we can thank you properly?

@plotsbot
Copy link
Collaborator

plotsbot commented Mar 17, 2019

2 Messages
📖 @Nirvikalpa108 Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖 It looks like you haven’t marked all the checkboxes. Help us review and accept your suggested changes by going through the steps one by one. If it is still a ‘Work in progress’, please include ‘[WIP]’ in the title.

Generated by 🚫 Danger

related = Tag.related(tags(:awesome).name)
assert !related.empty?
assert related.include?(tags(:test))
puts related.to_json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
puts related.to_json

I don't think that anything is to be printed here. So, there is no need for this statement.

@jywarren
Copy link
Member

@Nirvikalpa108 this is super! Perfect, i'm merging it now. Great work! 👍 🎉

@jywarren jywarren merged commit c402103 into publiclab:master Mar 18, 2019
@welcome
Copy link

welcome bot commented Mar 18, 2019

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page. Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

icarito pushed a commit to icarito/plots2 that referenced this pull request Apr 9, 2019
* added unit test for Tag.related method

* post review correction
SrinandanPai pushed a commit to SrinandanPai/plots2 that referenced this pull request May 5, 2019
* added unit test for Tag.related method

* post review correction
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants