-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added unit test for Tag.related method #5129
added unit test for Tag.related method #5129
Conversation
Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help. |
Generated by 🚫 Danger |
test/unit/tag_test.rb
Outdated
related = Tag.related(tags(:awesome).name) | ||
assert !related.empty? | ||
assert related.include?(tags(:test)) | ||
puts related.to_json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
puts related.to_json |
I don't think that anything is to be printed here. So, there is no need for this statement.
@Nirvikalpa108 this is super! Perfect, i'm merging it now. Great work! 👍 🎉 |
Congrats on merging your first pull request! 🙌🎉⚡️ Help others take their first stepNow that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌 Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕 People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉 Read about how to help support another newcomer here, or find other ways to offer mutual support here. |
* added unit test for Tag.related method * post review correction
* added unit test for Tag.related method * post review correction
Fixes #3480
Hi @jywarren thanks for all your help in getting me started with this codebase. I couldn't run the tests locally. I just get an error saying my Ruby version is not the same as that mentioned in Gemfile. I have some outstanding installation questions which I've asked in an issue for first-timers installing. Hopefully I'll get that sorted soon! Otherwise, let me know if I've done this PR correctly? Thank you so much!! 😃
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment below