Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing non-working links at profile page #5192

Merged
merged 2 commits into from
Mar 20, 2019

Conversation

shubhi2000
Copy link
Contributor

@shubhi2000 shubhi2000 commented Mar 20, 2019

Fixes #5021 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

Copy link
Member

@CleverFool77 CleverFool77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @shubhi2000 Can we have a descriptive PR name explaining the changes done in few words instead of update show.html.erb

@plotsbot
Copy link
Collaborator

plotsbot commented Mar 20, 2019

2 Messages
📖 @shubhi2000 Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖 It looks like you haven’t marked all the checkboxes. Help us review and accept your suggested changes by going through the steps one by one. If it is still a ‘Work in progress’, please include ‘[WIP]’ in the title.

Generated by 🚫 Danger

@CleverFool77 CleverFool77 mentioned this pull request Mar 20, 2019
5 tasks
@shubhi2000
Copy link
Contributor Author

@CleverFool77 yeah sure. Is it possible for me to make changes in the name now?

@IshaGupta18 IshaGupta18 changed the title Update show.html.erb Fixing non-working links at profile page Mar 20, 2019
@IshaGupta18
Copy link
Collaborator

@gauravano I think this is good to be merged!

Co-Authored-By: shubhi2000 <46618557+shubhi2000@users.noreply.github.com>
Copy link
Member

@grvsachdeva grvsachdeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @shubhi2000!

@grvsachdeva grvsachdeva merged commit 80a2d79 into publiclab:master Mar 20, 2019
@welcome
Copy link

welcome bot commented Mar 20, 2019

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page. Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

@grvsachdeva
Copy link
Member

Merged 💯 🎉 🎈

@shubhi2000
Copy link
Contributor Author

Thank you soo much @gauravano, @CleverFool77, @madeofhuman , @IshaGupta18 for helping me out.

cesswairimu pushed a commit to cesswairimu/plots2 that referenced this pull request Mar 21, 2019
* Update show.html.erb

* Fixing non-working links at profile page

Co-Authored-By: shubhi2000 <46618557+shubhi2000@users.noreply.github.com>
jywarren pushed a commit that referenced this pull request Mar 29, 2019
* Update show.html.erb

* Fixing non-working links at profile page

Co-Authored-By: shubhi2000 <46618557+shubhi2000@users.noreply.github.com>
icarito pushed a commit to icarito/plots2 that referenced this pull request Apr 9, 2019
* Update show.html.erb

* Fixing non-working links at profile page

Co-Authored-By: shubhi2000 <46618557+shubhi2000@users.noreply.github.com>
SrinandanPai pushed a commit to SrinandanPai/plots2 that referenced this pull request May 5, 2019
* Update show.html.erb

* Fixing non-working links at profile page

Co-Authored-By: shubhi2000 <46618557+shubhi2000@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants