Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed broken links (#5049) #5254

Merged
merged 1 commit into from
Mar 28, 2019
Merged

Fixed broken links (#5049) #5254

merged 1 commit into from
Mar 28, 2019

Conversation

PritiShaw
Copy link
Member

@PritiShaw PritiShaw commented Mar 25, 2019

Added event listener to the links and added some custom styling for the same

image
screenShot-1
Fixes #5049
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • [✔️ ] PR is descriptively titled 📑 and links the original issue above 🔗
  • [ ✔️] tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • [✔️ ] code is in uniquely-named feature branch and has no merge conflicts 📁
  • [✔️ ] screenshots/GIFs are attached 📎 in case of UI updation
  • [ ✔️] ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

Added event listener to the links and added some custom styling for the same
@welcome
Copy link

welcome bot commented Mar 25, 2019

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄
Also, can you tell us your Twitter handle so we can thank you properly?

@plotsbot
Copy link
Collaborator

plotsbot commented Mar 25, 2019

2 Messages
📖 @PritiShaw Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖 It looks like you haven’t marked all the checkboxes. Help us review and accept your suggested changes by going through the steps one by one. If it is still a ‘Work in progress’, please include ‘[WIP]’ in the title.

Generated by 🚫 Danger

@PritiShaw
Copy link
Member Author

PritiShaw commented Mar 25, 2019

@gauravano Requesting help for solving the issue in CI

@grvsachdeva
Copy link
Member

Hmm, actually the error is not related to your changes. I have restarted the build here. Let's see how it goes. Also, apologies for replying late here.

Copy link
Member

@grvsachdeva grvsachdeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @PritiShaw!

@grvsachdeva
Copy link
Member

Although, I have tried your PR locally but please drop a screenshot below for reference. Thanks!

@PritiShaw
Copy link
Member Author

@gauravano I have attached the screenshots

@grvsachdeva grvsachdeva merged commit a2baded into publiclab:master Mar 28, 2019
@welcome
Copy link

welcome bot commented Mar 28, 2019

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page. Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

@grvsachdeva
Copy link
Member

Merged 🎉 🎈

@PritiShaw
Copy link
Member Author

Working in https://stable.publiclab.org/ :)

@PritiShaw PritiShaw deleted the patch-1 branch March 29, 2019 15:26
icarito pushed a commit to icarito/plots2 that referenced this pull request Apr 9, 2019
Added event listener to the links and added some custom styling for the same
SrinandanPai pushed a commit to SrinandanPai/plots2 that referenced this pull request May 5, 2019
Added event listener to the links and added some custom styling for the same
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants