Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start to pinning in notes grids (work in progress) #5681

Merged
merged 7 commits into from
May 20, 2019
Merged

Start to pinning in notes grids (work in progress) #5681

merged 7 commits into from
May 20, 2019

Conversation

jywarren
Copy link
Member

@jywarren jywarren commented May 7, 2019

Fixes #766

Not complete! would love help completing this!

It does need a test, with adding a pin here.

@plotsbot
Copy link
Collaborator

plotsbot commented May 7, 2019

1 Message
📖 @jywarren Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.

Generated by 🚫 Danger

@jywarren
Copy link
Member Author

jywarren commented May 9, 2019


ERROR["test_that_NodeShared_can_be_used_to_convert_short_codes_like_[nodes:foo]_into_tables_which_list_nodes_and_wikis(pages)", #<Minitest::Reporters::Suite:0x00007fa1a1c04438 @name="NodeSharedTest">, 150.35190430500006]
 test_that_NodeShared_can_be_used_to_convert_short_codes_like_[nodes:foo]_into_tables_which_list_nodes_and_wikis(pages)#NodeSharedTest (150.35s)
NoMethodError:         NoMethodError: undefined method `not' for #<Node::ActiveRecord_Relation:0x00007fa1a1c06d78>
        Did you mean?  none
            app/models/concerns/node_shared.rb:134:in `block in nodes_grid'
            app/models/concerns/node_shared.rb:116:in `gsub'
            app/models/concerns/node_shared.rb:116:in `nodes_grid'
            test/unit/node_shared_test.rb:6:in `block in <class:NodeSharedTest>'

@jywarren
Copy link
Member Author

jywarren commented May 9, 2019


 FAIL["test_posting_from_the_editor", #<Minitest::Reporters::Suite:0x000055bcba371190 @name="PostTest">, 15.581594264999922]
 test_posting_from_the_editor#PostTest (15.58s)
        expected to find visible css "h1" with text "My new post" but there were no matches. Also found "<<ERROR>>", which matched the selector but not all filters. 
        test/system/post_test.rb:25:in `block (2 levels) in <class:PostTest>'
        test/system/post_test.rb:37:in `assert_page_reloads'
        test/system/post_test.rb:22:in `block in <class:PostTest>'
[Screenshot]: tmp/screenshots/test_viewing_the_dashboard.png
[Screenshot]: tmp/screenshots/test_viewing_the_dashboard.png
 FAIL["test_search_Tag_Nearby_People_functionality", #<Minitest::Reporters::Suite:0x00007fd0593a4360 @name="SearchApiTest">, 88.03019992399993]
 test_search_Tag_Nearby_People_functionality#SearchApiTest (88.03s)
        Expected: "/profile/steff2"
          Actual: "/profile/steff3"
        test/functional/api/search_api_test.rb:230:in `block in <class:SearchApiTest>'

assert_equal 1, html.scan('<table class="table inline-grid nodes-grid nodes-grid-test nodes-grid-test-').length
assert_equal 1, html.scan('<table').length
assert_equal 5, html.scan('nodes-grid-test').length
assert html.scan('<td class="author">').length > 2 # but not 3 because it shouldn't appear twice
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


 FAIL["test_that_pinned_notes_with_\"pinned:foo\"_tags_appear_at_the_top_of_[nodes:foo]_inline_tables", #<Minitest::Reporters::Suite:0x00007fb378479478 @name="NodeSharedTest">, 80.94805819600003]
 test_that_pinned_notes_with_"pinned:foo"_tags_appear_at_the_top_of_[nodes:foo]_inline_tables#NodeSharedTest (80.95s)
        Expected false to be truthy.
        test/unit/node_shared_test.rb:23:in `block in <class:NodeSharedTest>'

@jywarren jywarren merged commit d0c98e2 into master May 20, 2019
This was referenced May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pin:_tagname_ powertag to pin items to tops of inline-grids that match the tag
2 participants