Adding question text area to the shadow question's page #5805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jywarren I don't understand where the test is failing. I don't think it is related to this. |
|
Is it in a system test? Those are still causing us some trouble, it seems.
Can you try restarting the tests? Sorry!!!!
…On Wed, May 29, 2019 at 6:10 PM Gautami Gupta ***@***.***> wrote:
@jywarren <https://github.com/jywarren> I don't understand where the test
is failing. I don't think it is related to this.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5805?email_source=notifications&email_token=AAAF6J2R52VI6EAY24SUBETPX35MFA5CNFSM4HQV4Y5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWQY6XY#issuecomment-497127263>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAF6JZLCSATDDA2SS537CLPX35MFANCNFSM4HQV4Y5A>
.
|
|
Yes @jywarren it is in the system test. |
|
I /think/ you should be able to restart just the system tests, but if not,
ping me and I can. Or you can close the PR and re-open it and it should
re-trigger all of them!
…On Wed, May 29, 2019 at 6:18 PM Gautami Gupta ***@***.***> wrote:
Yes @jywarren <https://github.com/jywarren> it is in the system test.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5805?email_source=notifications&email_token=AAAF6J62OKQNWPRUMCMC3L3PX36KFA5CNFSM4HQV4Y5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWQZN5Q#issuecomment-497129206>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAF6J74QNDUMPXJFPJXPODPX36KFANCNFSM4HQV4Y5A>
.
|
|
@jywarren I have made the changes and the tests are running again. Thanks!
|
|
awesome - ping reviewers once it passes and let's get it merged!
…On Wed, May 29, 2019 at 6:29 PM Gautami Gupta ***@***.***> wrote:
@jywarren <https://github.com/jywarren> I have made the changes and the
tests are running again. Thanks!
[image: Screen Shot 2019-05-30 at 4 00 43 AM]
<https://user-images.githubusercontent.com/35326753/58595703-2d181d00-828f-11e9-8e2e-093a257017f4.png>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5805?email_source=notifications&email_token=AAAF6J2DYGEMING37OUAYODPX37RFA5CNFSM4HQV4Y5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWQ2CGI#issuecomment-497131801>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAF6J2FK7U35QKKKMQD5JLPX37RFANCNFSM4HQV4Y5A>
.
|
|
@jywarren @CleverFool77 @gauravano Tests have passed and the PR is ready for review. |
|
Awesome! I'll merge this then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5733 (<=== Add issue number here)
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test@publiclab/reviewersfor help, in a comment belowIf tests do fail, click on the red
Xto learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!