Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tooltips to follow button and tools dropdown on the like bar #5823

Merged
merged 2 commits into from
Jun 6, 2019

Conversation

michelelong
Copy link
Contributor

@michelelong michelelong commented Jun 2, 2019

Fixes #5820
tools-tooltip
follow-tooltip

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@welcome
Copy link

welcome bot commented Jun 2, 2019

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄
It would be great if you can tell us your Twitter handle so we can thank you properly?

@michelelong
Copy link
Contributor Author

System test failed on: FAIL["test_viewing_the_dashboard", #<Minitest::Reporters::Suite:0x00007fc2a55e7378 @name="DashboardTest">, 65.62211653899999] which looks to be the error from issue #5683. I don't know what to do now. @publiclab/reviewers

@grvsachdeva
Copy link
Member

grvsachdeva commented Jun 4, 2019

Hi @michelelong, thanks for PR. Hmm, the test failure is not related to your code. yes, we are trying to solve that error #5683 and it seems that's the reason here too. I will just restart the build. Sorry for the false alarm.

@michelelong
Copy link
Contributor Author

inconsistant-fix

There was a weird inconsistency in the "flag as spam" and "like it" tooltips. On some pages like /blog they showed up underneath the button and without the arrow. Added data-tooltip and data-placement to them makes them show the same way on all pages.

space-problem

Under certain circumstances the author name was jammed up against the icon. I just added a non-breaking space to fix it.

print-fix

A more descriptive tooltip for the dropdown menu.

@jywarren
Copy link
Member

jywarren commented Jun 6, 2019 via email

Copy link
Member

@grvsachdeva grvsachdeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @michelelong!!

@grvsachdeva grvsachdeva merged commit 9eab2f1 into publiclab:master Jun 6, 2019
@grvsachdeva
Copy link
Member

Merged 🎉 🎈 👍

Looking forward to more of your awesome contributions 😄. And, let us know if you want to take on more complex tasks? Although, your help is very welcome with any of the https://github.com/publiclab/plots2/issues

Thanks!!

@michelelong michelelong deleted the like-tooltip-update branch June 6, 2019 15:32
enviro3 pushed a commit to enviro3/plots2 that referenced this pull request Aug 15, 2019
…liclab#5823)

* Add tooltips to follow and tools on the like bar

* Update tooltips on like bar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tooltips for interface consistency and clarity on wiki and blog
3 participants