-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tooltips to follow button and tools dropdown on the like bar #5823
Conversation
Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help. |
Hi @michelelong, thanks for PR. Hmm, the test failure is not related to your code. yes, we are trying to solve that error #5683 and it seems that's the reason here too. I will just restart the build. Sorry for the false alarm. |
There was a weird inconsistency in the "flag as spam" and "like it" tooltips. On some pages like /blog they showed up underneath the button and without the arrow. Added data-tooltip and data-placement to them makes them show the same way on all pages. Under certain circumstances the author name was jammed up against the icon. I just added a non-breaking space to fix it. A more descriptive tooltip for the dropdown menu. |
This looks awesome!!!
…On Tue, Jun 4, 2019, 5:25 PM Michele ***@***.***> wrote:
[image: inconsistant-fix]
<https://user-images.githubusercontent.com/50340123/58914670-c064ae80-86e4-11e9-8074-2e344409be29.png>
There was a weird inconsistency in the "flag as spam" and "like it"
tooltips. On some pages like /blog they showed up underneath the button and
without the arrow. Added data-tooltip and data-placement to them makes them
show the same way on all pages.
[image: space-problem]
<https://user-images.githubusercontent.com/50340123/58914434-17b64f00-86e4-11e9-94cc-260803ef5cc5.png>
Under certain circumstances the author name was jammed up against the
icon. I just added a non-breaking space to fix it.
[image: print-fix]
<https://user-images.githubusercontent.com/50340123/58914845-294c2680-86e5-11e9-8a91-bff1726c345d.png>
A more descriptive tooltip for the dropdown menu.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#5823?email_source=notifications&email_token=AAAF6J5XOKJAUS4ADWTYNALPY3MSPA5CNFSM4HSDYZY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODW55NVA#issuecomment-498849492>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAF6J4K5WY6Y7S2UWXK7YLPY3MSPANCNFSM4HSDYZYQ>
.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @michelelong!!
Merged 🎉 🎈 👍 Looking forward to more of your awesome contributions 😄. And, let us know if you want to take on more complex tasks? Although, your help is very welcome with any of the https://github.com/publiclab/plots2/issues Thanks!! |
…liclab#5823) * Add tooltips to follow and tools on the like bar * Update tooltips on like bar
Fixes #5820
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!