fix question area in question shadow page

[gautamig54]

Fixes #0000 (<=== Add issue number here)

Fixing the continue button on the question card.

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• PR is descriptively titled 📑 and links the original issue above 🔗
• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
• code is in uniquely-named feature branch and has no merge conflicts 📁
• screenshots/GIFs are attached 📎 in case of UI updation
• ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

[gautamig54]

@CleverFool77 This solves the issue. Thanks!

[jywarren]

Hi! We have a few ways to cause a login modal to appear when things are clicked, including links. Could this be helpful? Esp so people don't lose what they type into the box? https://github.com/publiclab/plots2/blob/b1c57446d016f8cd0ec149a75298711270e1643e/doc/LOGIN_SYSTEMS.md#how-to-setup-login-modal-on-various-locations

…

On Sat, Jun 8, 2019, 6:47 AM Gautami Gupta ***@***.***> wrote: @CleverFool77 <https://github.com/CleverFool77> This solves the issue. Thanks! — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#5860?email_source=notifications&email_token=AAAF6J5SOP5473SVOHNMJBDPZOZ4TA5CNFSM4HWHJNE2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXHU6LA#issuecomment-500125484>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAF6J3LW5BBVFE6TMSXXG3PZOZ4TANCNFSM4HWHJNEQ> .

[jywarren]

Hi Gautami, just checking if you saw this? Thanks!

[gautamig54]

Yes @jywarren. Sorry for the late reply. I looked into this.
It redirects the user to the login/signup page. So do you want to open a login modal instead of this?

[gautamig54]

I have implemented the modal here, but the issue is that it is redirected to the dashboard after login rather than on the shadow question's page.

[jywarren]

awesome, keep up the great work!

…

On Fri, Jun 14, 2019 at 4:31 AM Gautami Gupta ***@***.***> wrote: I have implemented the modal here, but the issue is that it is redirected to the dashboard after login rather than on the shadow question's page. I am working on that. [image: ezgif com-video-to-gif] <https://user-images.githubusercontent.com/35326753/59495377-c741ad00-8eac-11e9-8bff-8734e71425fb.gif> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5860?email_source=notifications&email_token=AAAF6J6MRZPJJ6GVJVUGT7DP2NJLXA5CNFSM4HWHJNE2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXWDQYQ#issuecomment-502020194>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAF6J2VRULDAKRQL7XQLG3P2NJLXANCNFSM4HWHJNEQ> .

[asquare14]

@gautamig54 Add an action which after login redirects to the shadow page. You could look at https://github.com/plataformatec/devise/wiki/How-To:-redirect-to-a-specific-page-on-successful-sign-in this! Devise documentation mentions how to to this :)

Also, rebase from master .

[jywarren]

Hi all! How is this going? Thank you!

[gautamig54]

Hi @gauravano. Can you look into this and guide. We already have a after_sign_in path function defined in application controller.
The modal works fine, but after login it is directed to the dashboard instead of the shadow page. What am I missing here?

[asquare14]

Were you able to resolve the issue ?

[grvsachdeva]

Hey @gautamig54, will look into this. Can you resolve conflicts here, so that I can fetch this PR locally and test it better. Also, this is the related issue right - #5733 ?

Also, have you set routes, yet?

[gautamig54]

Still facing this issue @asquare14.

[grvsachdeva]

You can use <%= link_to "", new_user_session_path( return_to: '/question_shadow' )%> for now and modify return_to according to the text.

[grvsachdeva]

<a class="btn btn-default" href="/login?return_to=/questions" role="button" aria-pressed="true"> Continue </a> is also working

[gautamig54]

<a class="btn btn-default" href="/login?return_to=/questions" role="button" aria-pressed="true"> Continue </a> is also working

Hi @gauravano! i tried doing this. The issue here is as soon as I click on login, the modal opens and then disappears and the login page opens up. This was the earlier implementation of the login/signup.
@jywarren wanted to implement modal here, so that the question written by user is retained even after logging in. Using this method returns the user to the questions_shadow page but deletes the content.

[asquare14]

Is the above issue resolved ? If not I could maybe test your code locally and help you figure out a solution .

[gautamig54]

Hi @asquare14! I tried both the suggestions that @gauravano suggested. None of them seem to work here.

[gautamig54]

Hi! Can we merge this for now?
I will make a follow up issue for the same here.

[jywarren]

I think this can be merged now, but let's check the screenshots just to be sure, once this finishes building and testing! 🎉 Thanks for your patience, all!

[jywarren]

Hm. I think it got duplicated:

[jywarren]

🎉