Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLpeopleLayer added to /people page #5961

Closed
wants to merge 5 commits into from

Conversation

sagarpreet-chadha
Copy link
Contributor

@sagarpreet-chadha sagarpreet-chadha commented Jun 29, 2019

Fixes #5874 .

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

Thanks!

@sagarpreet-chadha
Copy link
Contributor Author

Screenshot 2019-06-29 at 2 12 45 PM

@sagarpreet-chadha
Copy link
Contributor Author

@jywarren ...how to wait for js to load in capybara ?
wait_until is depreciated .

@sagarpreet-chadha
Copy link
Contributor Author

@jywarren
Copy link
Member

jywarren commented Jul 8, 2019

Hi, @sagarpreet-chadha -- when you click a grid square, what do you see? In the demo here: https://publiclab.github.io/leaflet-blurred-location-display/examples/index.html

image

... you just see how many markers. Sorry, just catching up here - in this implementation, do you see a list of people instead of a count of markers?

@sagarpreet-chadha
Copy link
Contributor Author

Hi @jywarren ,
No we do not show the list of people name , we show count of markers . If we wish to show the former , we can do that in next release of LBLD ?
What do you say ?

@jywarren
Copy link
Member

jywarren commented Jul 9, 2019 via email

@jywarren
Copy link
Member

Hi @sagarpreet-chadha would you mind linking to an issue in LEL for this? Thanks!

@jywarren jywarren added this to the Geographic features milestone Jan 2, 2020
@jywarren jywarren changed the base branch from master to main June 30, 2020 18:00
@stale
Copy link

stale bot commented Oct 7, 2020

Hi 😄, this issue has been automatically marked as stale because it has not had recent activity. Don't worry you can continue to work on this and ask @publiclab/reviewers to add "work in progress" label 🎉 . Otherwise, it will be closed if no further activity occurs in 5 days -- but you can always re-open it if you like! 💯 Thank you for your contributions 🙌 🎈.

@stale stale bot added the stale label Oct 7, 2020
@jywarren
Copy link
Member

Hi! just noting this now exists via the LEL people layer! Thank you!!!!

@jywarren jywarren closed this Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add PLpeopleLayer from LEL .
2 participants