Fix tagging user profiles and add JS ajax function #6886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jywarren
reviewed
Dec 2, 2019
test/system/tag_test.rb
Outdated
| @@ -5,26 +5,47 @@ | |||
| class TagTest < ApplicationSystemTestCase | |||
| Capybara.default_max_wait_time = 60 | |||
|
|
|||
| test 'adding a tag via javascript' do | |||
| visit '/' | |||
| # test 'adding a tag via javascript' do | |||
There was a problem hiding this comment.
Just checking, did you want to comment all these out?
|
Oops, no I didn't mean to leave those uncommented! Pushed up the fix. Oh that would be great if it solved that! I'll check it out! |
Screenshots 📸 (click to expand)6886-test_questions.png6886-test_embeddable_grids.png6886-test_signup.png6886-test_viewing_the_settings_page.png6886-test_tag_by_author_page.png6886-test_wiki_page_with_inline_grids.png6886-test_stats.png6886-test_viewing_the_dashboard.png6886-test_searching_an_item_from_the_homepage.png6886-test_questions_shadow.png6886-test_login_modal.png6886-test_profile_page.png6886-test_comments.png6886-test_tags.png6886-test_signup_modal.png6886-test_wiki.png6886-test_methods.png6886-test_tag_page.png6886-test_blog_page_with_location_modal.png6886-test_tag_wildcard.png6886-test_embeddable_thumbnail_grids.png6886-test_front_page_with_navbar_search_autocomplete.png6886-test_login.png6886-test_viewing_the_dropdown_menu.png6886-test_viewing_question_post.png6886-test_mobile_displays.png6886-test_simple-data-grapher_powertag.png6886-test_front.png6886-test_question_page.png6886-test_tag_contributors_page.png6886-test_blog.png6886-test_people.png6886-test_wiki_revisions.pngLearn about automated screenshots Generated by 🚫 Danger |
jywarren
approved these changes
Dec 2, 2019
|
Merging! Thanks -- you're killing it on the system tests! This is super!!! |
|
Aha, this issue may also be solved by your new code, though it may also need some tweaking now! |
|
Oh sorry that is the exact same issue. Just doing some cleanup and... made it worse! Ignore!!! |
vinitshahdeo
pushed a commit
to vinitshahdeo/plots2
that referenced
this pull request
Feb 1, 2020
* add correct url to user tag form and add test for adding user tag with JS * fix styling of delete button on badges in tags * uncomment tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6724 (<=== Add issue number here)
@jywarren This references what we talked about in #6422 - do I need to create an issue for this?
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test@publiclab/reviewersfor help, in a comment below+++
In this PR:
The badges for the node tags:
Badges for the user profile tags:
