Fix add your location on /people/ page #6895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well it looks like I'll be figuring out why the changes are causing errors in the tests! |
|
What it looks like when the user already has a location: What it looks like when the user doesnt: Re-styling the button to match the style guide will be posted as a fto-candidate or gci task. :) |
|
Looks amazing! Yeah, the only thing left to style on the button is changing the color attribute! Thanks so much!!!! |
vinitshahdeo
pushed a commit
to vinitshahdeo/plots2
that referenced
this pull request
Feb 1, 2020
* add parameter to pass url to addTag * remove alerts and uncomment * fix error - check if user is logged in
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5882 (<=== Add issue number here)
This button wasn't working because there was no form and no URL to submit to.
This PR adds a URL as an attribute to the
Add your locationlink, and checks for that attribute in the javascript code.It also doesn't show the button link if the user already has a location entered.
rake test@publiclab/reviewersfor help, in a comment below