Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed inconsistency in wiki/new toolbar icon. Icon and Text colour changed to #222 and hover color to white . #6956

Merged
merged 4 commits into from
Dec 16, 2019

Conversation

smarty1palak
Copy link
Contributor

Fixes #6519

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Screenshot from 2019-12-12 21-21-31
Screenshot from 2019-12-12 21-26-09

Thanks!

@welcome
Copy link

welcome bot commented Dec 12, 2019

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄
It would be great if you can tell us your Twitter handle so we can thank you properly?

@smarty1palak smarty1palak changed the title Removed inconsistency in wiki/new toolbar icon. Icon and Text colour changed to #222 and hover color to white . #6519 Removed inconsistency in wiki/new toolbar icon. Icon and Text colour changed to #222 and hover color to white . Dec 12, 2019
@smarty1palak
Copy link
Contributor Author

@nstjean can you guide me here? What could be the reason of failure? I am unable to figure out.

@nstjean
Copy link
Contributor

nstjean commented Dec 13, 2019

@smarty1palak Sure! Let's take a look!

@nstjean
Copy link
Contributor

nstjean commented Dec 13, 2019

Ahh, these are issues that are unrelated to your code, this is popping up on pull requests and I'm not sure why. I know they are working on it! So if you can just be patient, once that's fixed this will be merged, but this looks good! Thank you!! :)

@smarty1palak
Copy link
Contributor Author

Sure thanks !

Copy link
Contributor

@nstjean nstjean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code works! But do you think we could make it a little cleaner? CSS lets us specify an entire group of things together! Instead of adding a new selector class onto everything you can refer to all the button content with this:
.btn-toolbar .btn-outline-secondary
This means that any button within the toolbar will get the properties. This is really useful because you don't have to touch the links and buttons themselves! And any new button will automatically be styled the same way.

Similarly you can use this for the hover state:
.btn-toolbar .btn-outline-secondary:hover
You may need to use !important on the hover color because it is set to inherit.

@smarty1palak
Copy link
Contributor Author

Okay sure will make the changes .

Copy link
Contributor

@nstjean nstjean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! Thank you!! 😄

@jywarren jywarren merged commit 8aa3eb0 into publiclab:master Dec 16, 2019
@welcome
Copy link

welcome bot commented Dec 16, 2019

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Do join our weekly check-in to share your this week goal and the awesome work you did 😃. Please find the link pinned in the issue section 📝
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page. Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

@jywarren
Copy link
Member

Thanks all! This is fabulous! 🎉

Tlazypanda pushed a commit to Tlazypanda/plots2 that referenced this pull request Jan 14, 2020
…changed to publiclab#222 and hover color to white . (publiclab#6956)

* wiki/new toolbar icon colour changed to black and hover color to white

* error fixed

* changes suggested
vinitshahdeo pushed a commit to vinitshahdeo/plots2 that referenced this pull request Feb 1, 2020
…changed to publiclab#222 and hover color to white . (publiclab#6956)

* wiki/new toolbar icon colour changed to black and hover color to white

* error fixed

* changes suggested
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

What color should toolbar buttons be?
3 participants