-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed inconsistency in wiki/new toolbar icon. Icon and Text colour changed to #222 and hover color to white . #6956
Conversation
Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help. |
@nstjean can you guide me here? What could be the reason of failure? I am unable to figure out. |
@smarty1palak Sure! Let's take a look! |
Ahh, these are issues that are unrelated to your code, this is popping up on pull requests and I'm not sure why. I know they are working on it! So if you can just be patient, once that's fixed this will be merged, but this looks good! Thank you!! :) |
Sure thanks ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code works! But do you think we could make it a little cleaner? CSS lets us specify an entire group of things together! Instead of adding a new selector class onto everything you can refer to all the button content with this:
.btn-toolbar .btn-outline-secondary
This means that any button within the toolbar will get the properties. This is really useful because you don't have to touch the links and buttons themselves! And any new button will automatically be styled the same way.
Similarly you can use this for the hover state:
.btn-toolbar .btn-outline-secondary:hover
You may need to use !important
on the hover color because it is set to inherit.
Okay sure will make the changes . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent! Thank you!! 😄
Congrats on merging your first pull request! 🙌🎉⚡️ Help others take their first stepNow that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌 Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕 People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉 Read about how to help support another newcomer here, or find other ways to offer mutual support here. |
Thanks all! This is fabulous! 🎉 |
…changed to publiclab#222 and hover color to white . (publiclab#6956) * wiki/new toolbar icon colour changed to black and hover color to white * error fixed * changes suggested
…changed to publiclab#222 and hover color to white . (publiclab#6956) * wiki/new toolbar icon colour changed to black and hover color to white * error fixed * changes suggested
Fixes #6519
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!