Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: "Post note" form overflow #6973

Merged
merged 1 commit into from
Dec 16, 2019
Merged

FIX: "Post note" form overflow #6973

merged 1 commit into from
Dec 16, 2019

Conversation

VladimirMikulic
Copy link
Contributor

@VladimirMikulic VladimirMikulic commented Dec 15, 2019

In the old UI, the map and drop-image elements were cut off the screen.
This change makes them responsive.

Resolves #6970

Screenshot_20191215_191929

Screenshot_20191215_192045

@keshav234156 @SidharthBansal could you review this, please?

In the old UI, the map and drop-image elements were cut off the screen.
This change makes them responsive.

Resolves #6970
@jywarren
Copy link
Member

Thanks!!! @nstjean would you mind reviewing this? Thank you!

Copy link
Contributor

@nstjean nstjean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works perfectly! Thank you! 🎉

@VladimirMikulic
Copy link
Contributor Author

VladimirMikulic commented Dec 16, 2019

@jywarren it's ready for merge. @keshav234156 could you approve the task on GCI?
Thank you.

@SidharthBansal SidharthBansal merged commit 8cb0f37 into publiclab:master Dec 16, 2019
@SidharthBansal
Copy link
Member

Well done. I couldn't find the task link. Please tell me the task link so that I can approve

@VladimirMikulic
Copy link
Contributor Author

@keshav234156 approved it a few minutes ago.
Thanks anyway @SidharthBansal :)

@VladimirMikulic VladimirMikulic deleted the fix/post-form-overflow branch December 16, 2019 17:41
Tlazypanda pushed a commit to Tlazypanda/plots2 that referenced this pull request Jan 14, 2020
In the old UI, the map and drop-image elements were cut off the screen.
This change makes them responsive.

Resolves publiclab#6970
vinitshahdeo pushed a commit to vinitshahdeo/plots2 that referenced this pull request Feb 1, 2020
In the old UI, the map and drop-image elements were cut off the screen.
This change makes them responsive.

Resolves publiclab#6970
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New post form goes off-screen at small screen sizes
4 participants