Save zoom in location modal #7020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, looks like this may have a couple conflicts to resolve? Thanks! |
nstjean
force-pushed
the
save-zoom-in-location-modal
branch
from
212bc0e
to
9e6f464
Compare
|
@jywarren I removed those package files! |
|
I don't know why there's an error, it's saying |
|
Did we bump LBL to latest version? |
|
Yes we already did. |
|
Looks good now, shall we merge? Thanks! |
|
Yes it's passing now! |
|
Great! |
Tlazypanda
pushed a commit
to Tlazypanda/plots2
that referenced
this pull request
Jan 14, 2020
vinitshahdeo
pushed a commit
to vinitshahdeo/plots2
that referenced
this pull request
Feb 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7019 (<=== Add issue number here)
This PR adds
zoom:xxto the tags list when saving a location in the popup modal.I wasn't sure if yarn.lock should be added to the list of files in the commit? Google tells me it should be, but if I shouldn't then let me know and I'll remove it.