typo replace omment with comment #7042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## codecov #7042 +/- ##
==========================================
Coverage ? 74.67%
==========================================
Files ? 89
Lines ? 5402
Branches ? 0
==========================================
Hits ? 4034
Misses ? 1368
Partials ? 0Continue to review full report at Codecov.
|
Closed
|
Hey @kaustubh-nair and @jywarren the codecov bot worked on this pr. I've been looking around a lot to figure things out but don't understand why the travis is failing although it mentions problems with the mysql server. I'm going to look at the |
|
What do you guys think @debck @ananyaarun @keshav234156? |
jywarren
approved these changes
Dec 29, 2019
|
Wow amazing! Ready to merge? |
|
Thanks @jywarren! Yeah I think we can merge it 😄 |
jywarren
added a commit
that referenced
this pull request
Jan 2, 2020
* Remove coveralls, add codecov * Add env variable * Comment reporting lines * Change env variable * Remove coveralls from rake file * Fix travis and rakefile * Remove project for codecov * Remove old reports before running * typo replace omment with comment (#7042) * typo replace omment with comment * Update blog.css * Update .travis.yml * Update .travis.yml * add codecov branch to travis for debugging Co-authored-by: Uzay-G <52892257+Uzay-G@users.noreply.github.com> Co-authored-by: Jeffrey Warren <jeff@unterbahn.com>
Tlazypanda
pushed a commit
to Tlazypanda/plots2
that referenced
this pull request
Jan 14, 2020
* Remove coveralls, add codecov * Add env variable * Comment reporting lines * Change env variable * Remove coveralls from rake file * Fix travis and rakefile * Remove project for codecov * Remove old reports before running * typo replace omment with comment (publiclab#7042) * typo replace omment with comment * Update blog.css * Update .travis.yml * Update .travis.yml * add codecov branch to travis for debugging Co-authored-by: Uzay-G <52892257+Uzay-G@users.noreply.github.com> Co-authored-by: Jeffrey Warren <jeff@unterbahn.com>
vinitshahdeo
pushed a commit
to vinitshahdeo/plots2
that referenced
this pull request
Feb 1, 2020
* Remove coveralls, add codecov * Add env variable * Comment reporting lines * Change env variable * Remove coveralls from rake file * Fix travis and rakefile * Remove project for codecov * Remove old reports before running * typo replace omment with comment (publiclab#7042) * typo replace omment with comment * Update blog.css * Update .travis.yml * Update .travis.yml * add codecov branch to travis for debugging Co-authored-by: Uzay-G <52892257+Uzay-G@users.noreply.github.com> Co-authored-by: Jeffrey Warren <jeff@unterbahn.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6290
I think there is an error here and the
ommentshould be replaced withcommentinstead for the codecov configuration.I might be wrong but I think it might be something worth trying out to solve the codecov coverage issues.
Thanks!