Use default location lat lon for /map/ #7046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When logged in with a profile location saved: When not logged in / no profile location: |
|
I discovered that if a lat or lon of 0 was passed in via the params or by a user's profile that it was evaluating as false and using the default value instead. I have corrected this. |
sagarpreet-chadha
requested changes
Jan 1, 2020
|
I made the clean up changes in #7061 |
|
Should this be merged now? Before or after #7061? Thanks!!!! |
|
@jywarren Before, thank you!!! |
|
:-) all good i guess! Thanks! |
Tlazypanda
pushed a commit
to Tlazypanda/plots2
that referenced
this pull request
Jan 14, 2020
* change default values to use params, then user tags, then default * clean up code * fix rubocop error, rename user location variables * fix trailing whitespace * fix bug where lat or lon of 0 is not used
vinitshahdeo
pushed a commit
to vinitshahdeo/plots2
that referenced
this pull request
Feb 1, 2020
* change default values to use params, then user tags, then default * clean up code * fix rubocop error, rename user location variables * fix trailing whitespace * fix bug where lat or lon of 0 is not used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7045 (<=== Add issue number here)