Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix map on profile and add check for zoom tag #7089

Merged
merged 2 commits into from
Jan 2, 2020

Conversation

nstjean
Copy link
Contributor

@nstjean nstjean commented Jan 2, 2020

Fixes #7088 (<=== Add issue number here)

I have the map working now, and it's checking for the user's zoom value.

FireShot Capture 163 - 🎈 Public Lab_ admin - localhost

I notice this is very very similar to the maps in the page sidebar. Is there a reason we are using a separate template for this map? Should we consider consolidating into one template?

@codecov
Copy link

codecov bot commented Jan 2, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@dfb7d2d). Click here to learn what that means.
The diff coverage is 55.55%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #7089   +/-   ##
=========================================
  Coverage          ?   80.68%           
=========================================
  Files             ?       97           
  Lines             ?     5567           
  Branches          ?        0           
=========================================
  Hits              ?     4492           
  Misses            ?     1075           
  Partials          ?        0
Impacted Files Coverage Δ
app/controllers/map_controller.rb 42.44% <0%> (ø)
app/controllers/users_controller.rb 80.98% <100%> (ø)
app/helpers/application_helper.rb 83.13% <75%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfb7d2d...01000a3. Read the comment docs.

@jywarren
Copy link
Member

jywarren commented Jan 2, 2020

I think we can consolidate, yes! I'm going to merge this now to test a theory about CodeCov we're seeing in #5954 -- cc @Uzay-G

Thank you!

@jywarren jywarren merged commit 6d86748 into publiclab:master Jan 2, 2020
@nstjean
Copy link
Contributor Author

nstjean commented Jan 3, 2020

Ok! I'll consolidate in a different PR. :)

Tlazypanda pushed a commit to Tlazypanda/plots2 that referenced this pull request Jan 14, 2020
* add zoom to profile map, fix error on map so it shows correctly

* clean up code
vinitshahdeo pushed a commit to vinitshahdeo/plots2 that referenced this pull request Feb 1, 2020
* add zoom to profile map, fix error on map so it shows correctly

* clean up code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix map on user profile
2 participants