Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build error re: glify.js include #7157

Merged
merged 10 commits into from
Jan 9, 2020

Conversation

crisner
Copy link
Contributor

@crisner crisner commented Jan 9, 2020

Fixes #7158 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@codecov
Copy link

codecov bot commented Jan 9, 2020

Codecov Report

Merging #7157 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7157   +/-   ##
=======================================
  Coverage   80.83%   80.83%           
=======================================
  Files          97       97           
  Lines        5572     5572           
=======================================
  Hits         4504     4504           
  Misses       1068     1068

@crisner crisner changed the title Fix build error [WIP] Fix build error Jan 9, 2020
@crisner
Copy link
Contributor Author

crisner commented Jan 9, 2020

@jywarren,

I tried a clean install of the plots2 repo to be sure and the files seem to be in the right places.

We are having errors connected to glify.js,
Rack app error handling request { GET /lib/leaflet-environmental-layers/example/lib/glify.js }
#<ActionController::RoutingError: No route matches [GET] "/lib/leaflet-environmental-layers/example/lib/glify.js">

Could it be possible that there is another file looking for glify.js in the old location? There don't seem to be any errors involving fullUrlHash.js.

@crisner crisner changed the title [WIP] Fix build error Fix build error Jan 9, 2020
@crisner
Copy link
Contributor Author

crisner commented Jan 9, 2020

@jywarren, all checks pass now! 🎉

@jywarren jywarren changed the title Fix build error Fix build error re: glify.js include Jan 9, 2020
@jywarren
Copy link
Member

jywarren commented Jan 9, 2020

Fantastic! Thanks for figuring this one out!

@jywarren jywarren merged commit c6ef871 into publiclab:master Jan 9, 2020
Tlazypanda pushed a commit to Tlazypanda/plots2 that referenced this pull request Jan 14, 2020
* Change script path in map dependancies to match with LEL publiclab#6978

* change #1

* change #2

* update to original task

* Bump leaflet-environmental-layers from 2.0.6 to 2.1.7

Bumps [leaflet-environmental-layers](https://github.com/publiclab/leaflet-environmental-layers) from 2.0.6 to 2.1.7.
- [Release notes](https://github.com/publiclab/leaflet-environmental-layers/releases)
- [Commits](https://github.com/publiclab/leaflet-environmental-layers/commits)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Bump leaflet-environmental-layers from 2.0.6 to 2.1.7

* Update dependency path

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: Bear Kruz <16524769+bearkruz@users.noreply.github.com>
vinitshahdeo pushed a commit to vinitshahdeo/plots2 that referenced this pull request Feb 1, 2020
* Change script path in map dependancies to match with LEL publiclab#6978

* change publiclab#1

* change publiclab#2

* update to original task

* Bump leaflet-environmental-layers from 2.0.6 to 2.1.7

Bumps [leaflet-environmental-layers](https://github.com/publiclab/leaflet-environmental-layers) from 2.0.6 to 2.1.7.
- [Release notes](https://github.com/publiclab/leaflet-environmental-layers/releases)
- [Commits](https://github.com/publiclab/leaflet-environmental-layers/commits)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Bump leaflet-environmental-layers from 2.0.6 to 2.1.7

* Update dependency path

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: Bear Kruz <16524769+bearkruz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failing after LEL update
3 participants