Add hostname value to display the correct embed code #7229
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7229 +/- ##
======================================
Coverage 81.5% 81.5%
======================================
Files 97 97
Lines 5602 5602
======================================
Hits 4566 4566
Misses 1036 1036 |
There was a problem hiding this comment.
Thanks for opening a pull request @NitinBhasneria! This is great
| @@ -97,6 +97,7 @@ | |||
| include: layersname, | |||
| hash: false, | |||
| embed: true, | |||
| hostname: 'publiclab.org', | |||
There was a problem hiding this comment.
Ah, can we ask @crisner to approve this? Thank you!!!
There was a problem hiding this comment.
@jywarren, I'll also add what this change does.
Adding hostname here would change the embed code in https://publiclab.org/map#lat=22.51255695405145&lon=9.843750000000002 page from //publiclab.github.io/map/#lat=22.51255695405145&lon=9.843750000000002 to //publiclab.org/map/#lat=22.51255695405145&lon=9.843750000000002.
|
@jywarren can I know why this "merging is blocked" showing? |
|
@NitinBhasneria, it appears as "merging is blocked" to unauthorized users. It means you don't have the permissions to merge the PR to the master branch. |
|
Ok, this is super, let's merge!!! 🙌🏽 |
Fixes #7217 (<=== Add issue number here)
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test@publiclab/reviewersfor help, in a comment belowIf tests do fail, click on the red
Xto learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!