Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move map dependencies to header to fix error with map popups not working #7371

Merged
merged 1 commit into from
Jan 28, 2020

Conversation

nstjean
Copy link
Contributor

@nstjean nstjean commented Jan 28, 2020

Fixes #7281 (<=== Add issue number here)

Map dependencies cannot be included multiple times on a map without causing an error with the map popups. I have moved the include to the header file and removed it from the other pages. Now the popups work and all the other maps are still working as well.

FireShot Capture 241 - 🎈 Public Lab_ Inline Maps - localhost

FireShot Capture 243 - 🎈 Public Lab_ Notes on England - localhost

FireShot Capture 244 - 🎈 Public Lab_ Map - localhost

@codecov
Copy link

codecov bot commented Jan 28, 2020

Codecov Report

Merging #7371 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7371   +/-   ##
=======================================
  Coverage   81.73%   81.73%           
=======================================
  Files          97       97           
  Lines        5602     5602           
=======================================
  Hits         4579     4579           
  Misses       1023     1023

@plotsbot
Copy link
Collaborator

1 Warning
⚠️ There was an error with Danger bot’s Junit parsing: No JUnit file was found at output.xml
2 Messages
📖 @nstjean Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖 #
Screenshots 📸 (click to expand)

7371-test_questions.png

7371-test_embeddable_grids.png

7371-test_signup.png

7371-test_viewing_the_settings_page.png

7371-test_tag_by_author_page.png

7371-test_wiki_page_with_inline_grids.png

7371-test_stats.png

7371-test_viewing_the_dashboard.png

7371-test_searching_an_item_from_the_homepage.png

7371-test_signup_modal_form_validation.png

7371-test_tag_stats.png

7371-test_login_modal_form_validation.png

7371-test_questions_shadow.png

7371-test_login_modal.png

7371-test_profile_page.png

7371-test_comments.png

7371-test_tags.png

7371-test_signup_modal.png

7371-test_wiki.png

7371-test_methods.png

7371-test_tag_page.png

7371-test_blog_page_with_location_modal.png

7371-test_tag_wildcard.png

7371-test_signup_modal_disabled_submit_button_on_empty_username.png

7371-test_embeddable_thumbnail_grids.png

7371-test_front_page_with_navbar_search_autocomplete.png

7371-test_spam_moderation_page.png

7371-test_login.png

7371-test_viewing_the_dropdown_menu.png

7371-test_viewing_question_post.png

7371-test_mobile_displays.png

7371-test_simple-data-grapher_powertag.png

7371-test_front.png

7371-test_question_page.png

7371-test_tag_contributors_page.png

7371-test_blog.png

7371-test_people.png

7371-test_wiki_revisions.png

Learn about automated screenshots

Generated by 🚫 Danger

@jywarren jywarren merged commit a402992 into publiclab:master Jan 28, 2020
@jywarren
Copy link
Member

Rad!!! 🎉

@jywarren
Copy link
Member

This is live! Can you confirm it's working? thanks so much!!!

@nstjean
Copy link
Contributor Author

nstjean commented Jan 28, 2020

It looks great!!

FireShot Capture 247 - 🎈 Public Lab_ Inline maps - publiclab org

@jywarren
Copy link
Member

Hi, sorry, i'm just noticing some oddness with the unearthing layer here:

https://publiclab.org/wiki/onecranston#location

image

It seems that the zooming and layer loading are a little cross-wired. Like, i zoom but the unearthing layer doesn't. Could this have something to do with this PR, or something else we recently changed? cc @crisner as well -- thank you!

@nstjean
Copy link
Contributor Author

nstjean commented Jan 30, 2020

For me it looks like it does zoom properly after I am done with the zoom motion, but it doesn't react in between. Interesting. I don't think moving the dependency would have affected that but we are seeing some other weirdness too. I'll take a look.

vinitshahdeo pushed a commit to vinitshahdeo/plots2 that referenced this pull request Feb 1, 2020
NitinBhasneria pushed a commit to NitinBhasneria/plots2 that referenced this pull request Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Map popups not working
3 participants