-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move map dependencies to header to fix error with map popups not working #7371
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7371 +/- ##
=======================================
Coverage 81.73% 81.73%
=======================================
Files 97 97
Lines 5602 5602
=======================================
Hits 4579 4579
Misses 1023 1023 |
Screenshots 📸 (click to expand)7371-test_questions.png7371-test_embeddable_grids.png7371-test_signup.png7371-test_viewing_the_settings_page.png7371-test_tag_by_author_page.png7371-test_wiki_page_with_inline_grids.png7371-test_stats.png7371-test_viewing_the_dashboard.png7371-test_searching_an_item_from_the_homepage.png7371-test_signup_modal_form_validation.png7371-test_tag_stats.png7371-test_login_modal_form_validation.png7371-test_questions_shadow.png7371-test_login_modal.png7371-test_profile_page.png7371-test_comments.png7371-test_tags.png7371-test_signup_modal.png7371-test_wiki.png7371-test_methods.png7371-test_tag_page.png7371-test_blog_page_with_location_modal.png7371-test_tag_wildcard.png7371-test_signup_modal_disabled_submit_button_on_empty_username.png7371-test_embeddable_thumbnail_grids.png7371-test_front_page_with_navbar_search_autocomplete.png7371-test_spam_moderation_page.png7371-test_login.png7371-test_viewing_the_dropdown_menu.png7371-test_viewing_question_post.png7371-test_mobile_displays.png7371-test_simple-data-grapher_powertag.png7371-test_front.png7371-test_question_page.png7371-test_tag_contributors_page.png7371-test_blog.png7371-test_people.png7371-test_wiki_revisions.pngLearn about automated screenshots Generated by 🚫 Danger |
Rad!!! 🎉 |
This is live! Can you confirm it's working? thanks so much!!! |
Hi, sorry, i'm just noticing some oddness with the unearthing layer here: https://publiclab.org/wiki/onecranston#location It seems that the zooming and layer loading are a little cross-wired. Like, i zoom but the unearthing layer doesn't. Could this have something to do with this PR, or something else we recently changed? cc @crisner as well -- thank you! |
For me it looks like it does zoom properly after I am done with the zoom motion, but it doesn't react in between. Interesting. I don't think moving the dependency would have affected that but we are seeing some other weirdness too. I'll take a look. |
Fixes #7281 (<=== Add issue number here)
Map dependencies cannot be included multiple times on a map without causing an error with the map popups. I have moved the include to the header file and removed it from the other pages. Now the popups work and all the other maps are still working as well.