FIX: Wiki revisions test #7396
Merged
FIX: Wiki revisions test #7396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test has already been fixed before but recently it has failed again in #7319. The problem might be related to our selection of "Revert" button. Inside of the button we have an empty space before the text and a font-awesome icon(<i>). We were selecting the button with #row0 and the text of "Revert" which probably caused the issue. I've added the btn-revert class to avoid this strange behaviour.
Codecov Report
@@ Coverage Diff @@
## master #7396 +/- ##
==========================================
+ Coverage 81.74% 81.87% +0.12%
==========================================
Files 97 97
Lines 5604 5604
==========================================
+ Hits 4581 4588 +7
+ Misses 1023 1016 -7
|
Uzay-G
approved these changes
Jan 30, 2020
|
Thanks @Uzay-G. @SidharthBansal it's ready. |
vinitshahdeo
pushed a commit
to vinitshahdeo/plots2
that referenced
this pull request
Feb 1, 2020
This test has already been fixed before but recently it has failed again in publiclab#7319. The problem might be related to our selection of "Revert" button. Inside of the button we have an empty space before the text and a font-awesome icon(<i>). We were selecting the button with #row0 and the text of "Revert" which probably caused the issue. I've added the btn-revert class to avoid this strange behaviour.
NitinBhasneria
pushed a commit
to NitinBhasneria/plots2
that referenced
this pull request
Feb 5, 2020
This test has already been fixed before but recently it has failed again in publiclab#7319. The problem might be related to our selection of "Revert" button. Inside of the button we have an empty space before the text and a font-awesome icon(<i>). We were selecting the button with #row0 and the text of "Revert" which probably caused the issue. I've added the btn-revert class to avoid this strange behaviour.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test has already been fixed before but recently it has failed again
in #7319. The problem might be related to our selection of "Revert"
button.
Inside of the button, we have an empty space before the text
and a font-awesome icon(<i>).
We were selecting the button with #row0 and the text of "Revert" which
probably caused the issue.
I've added the
btn-revertclass to avoid this strange behaviour.