-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Map control layers #7425
Map control layers #7425
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7425 +/- ##
==========================================
+ Coverage 81.76% 81.88% +0.12%
==========================================
Files 97 97
Lines 5604 5604
==========================================
+ Hits 4582 4589 +7
+ Misses 1022 1015 -7
|
aed8efb
to
913f7cf
Compare
@cesswairimu Do you have any idea why this is failing?
I ran the test on my local and it passes. |
Ok so changing the sidebar's z-index back to 9999 gave me a passing test. I'll have to see how I can do this. |
So something is obscuring the link in the sidebar when I drop the z-index down. Even though there shouldn't be anything else in the way. |
e1f8ea4
to
5a479ad
Compare
Oh sorry, just seeing this now...glad you fixed the issue 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome 🚀
* change map z-index so layers browser menu is on top * fix sidebar map-menu z-index layer bug * tag test change to wiki page, not comments
Fixes #7395 (<=== Add issue number here)
In order to fix this bug I had to remove z-index from the fullwidth maps and lower the sidebar z-index to 700.
the way the layers should display on the page should have the content side bar BETWEEN the map display layers and the map controls.
@crisner Take a look at this and tell me if you see anything that gets broken because of these changes.
=============
Z-INDEX of items on page:
.popover : 1060
#header : 1030
#anniversary : 999
.leaflet-top : 1000
(changed in #7419 to 800).leaflet-bottom : 1000
.dropdown-menu.show : 1000
.sidebar-panel : 700
.leaflet-layer : 1
.leaflet-map : auto