Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map control layers #7425

Merged
merged 3 commits into from
Feb 4, 2020
Merged

Conversation

nstjean
Copy link
Contributor

@nstjean nstjean commented Feb 3, 2020

Fixes #7395 (<=== Add issue number here)

In order to fix this bug I had to remove z-index from the fullwidth maps and lower the sidebar z-index to 700.

the way the layers should display on the page should have the content side bar BETWEEN the map display layers and the map controls.

FireShot Capture 272 - 🎈 Public Lab_ Inline Maps - localhost

FireShot Capture 273 - 🎈 Public Lab_ Inline Maps - localhost

@crisner Take a look at this and tell me if you see anything that gets broken because of these changes.

=============

Z-INDEX of items on page:

.popover : 1060
#header : 1030
#anniversary : 999
.leaflet-top : 1000 (changed in #7419 to 800)
.leaflet-bottom : 1000
.dropdown-menu.show : 1000
.sidebar-panel : 700
.leaflet-layer : 1
.leaflet-map : auto

@nstjean nstjean requested a review from a team as a code owner February 3, 2020 17:45
@codecov
Copy link

codecov bot commented Feb 3, 2020

Codecov Report

Merging #7425 into master will increase coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7425      +/-   ##
==========================================
+ Coverage   81.76%   81.88%   +0.12%     
==========================================
  Files          97       97              
  Lines        5604     5604              
==========================================
+ Hits         4582     4589       +7     
+ Misses       1022     1015       -7
Impacted Files Coverage Δ
app/api/srch/search.rb 69.28% <0%> (+3.92%) ⬆️
app/services/execute_search.rb 94.44% <0%> (+5.55%) ⬆️

@nstjean
Copy link
Contributor Author

nstjean commented Feb 4, 2020

@cesswairimu Do you have any idea why this is failing?

ERROR["test_removing_tags_from_the_post", #<Minitest::Reporters::Suite:0x00007f0e46e0ffa0 @name="PostTest">, 53.964613542999984]
 test_removing_tags_from_the_post#PostTest (53.96s)
Minitest::UnexpectedError:         Mysql2::Error: 
            app/controllers/tag_controller.rb:396:in `delete'

I ran the test on my local and it passes.

@nstjean
Copy link
Contributor Author

nstjean commented Feb 4, 2020

Ok so changing the sidebar's z-index back to 9999 gave me a passing test. I'll have to see how I can do this.

@nstjean
Copy link
Contributor Author

nstjean commented Feb 4, 2020

ERROR["test_adding_a_location_to_the_wiki", #<Minitest::Reporters::Suite:0x00007fb1c485ec10 @name="PostTest">, 98.45809273000003]
 test_adding_a_location_to_the_wiki#PostTest (98.46s)
Minitest::UnexpectedError:         Selenium::WebDriver::Error::ElementClickInterceptedError: element click intercepted: Element <a href="#" id="coord_button">...</a> is not clickable at point (885, 195). Other element would receive the click: <div class="modal-backdrop show"></div>
          (Session info: headless chrome=75.0.3770.142)
          (Driver info: chromedriver=74.0.3729.6 (255758eccf3d244491b8a1317aa76e1ce10d57e9-refs/branch-heads/3729@{#29}),platform=Linux 4.15.0-1028-gcp x86_64)
            test/system/post_test.rb:202:in `block in <class:PostTest>'

So something is obscuring the link in the sidebar when I drop the z-index down. Even though there shouldn't be anything else in the way.

@cesswairimu
Copy link
Collaborator

Oh sorry, just seeing this now...glad you fixed the issue 👍

Copy link
Collaborator

@cesswairimu cesswairimu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🚀

@cesswairimu cesswairimu merged commit da0c4f4 into publiclab:master Feb 4, 2020
NitinBhasneria pushed a commit to NitinBhasneria/plots2 that referenced this pull request Feb 5, 2020
* change map z-index so layers browser menu is on top

* fix sidebar map-menu z-index layer bug

* tag test change to wiki page, not comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sidebar is interfering with full-width inline maps
2 participants