Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minify leaflet scripts using uglifier #8159

Merged
merged 1 commit into from
Aug 18, 2020

Conversation

Tlazypanda
Copy link
Collaborator

Fixes #8158

Minified leaflet scripts using Uglifier.

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

Screenshots

Minify js suggestion not present anymore

after_mi

@gitpod-io
Copy link

gitpod-io bot commented Jul 17, 2020

@codecov
Copy link

codecov bot commented Jul 17, 2020

Codecov Report

Merging #8159 into main will increase coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8159      +/-   ##
==========================================
+ Coverage   82.10%   82.22%   +0.12%     
==========================================
  Files         100      100              
  Lines        5751     5751              
==========================================
+ Hits         4722     4729       +7     
+ Misses       1029     1022       -7     
Impacted Files Coverage Δ
app/api/srch/search.rb 70.06% <0.00%> (+3.82%) ⬆️
app/services/execute_search.rb 94.44% <0.00%> (+5.55%) ⬆️

@Tlazypanda
Copy link
Collaborator Author

@jywarren @cesswairimu can you kindly review? Thanks ✌️

@@ -16,6 +16,8 @@
# Compress JavaScripts and CSS
config.assets.compress = true
config.assets.js_compressor = Uglifier.new(harmony: true)
Uglifier.new(harmony: true).compile(File.read("public/lib/leaflet-environmental-layers/dist/LeafletEnvironmentalLayers.js"))
Uglifier.new(harmony: true).compile(File.read("public/lib/leaflet-environmental-layers/lib/glify.js"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will these then be grabbed automatically by asset pipeline? Awesome, thank you @Tlazypanda you're really an expert in all this!!!

@jywarren jywarren merged commit 563d229 into publiclab:main Aug 18, 2020
@Tlazypanda
Copy link
Collaborator Author

Tlazypanda commented Aug 26, 2020

@jywarren @cesswairimu on checking the performance the Uglifier scripts to be minified are not getting minified #8159 but locally they are so maybe fetching from cache can we do a manual rake assets:precompile (possibly after removing the assets folder once) and then letting it build a fresh assets folder 😅

@jywarren
Copy link
Member

Perhaps you could write this into a Rails migration, sit hat it automatically runs upon publishing to stable and production? What do you think? I'm happy to help with that if you want to open a PR !

nadimakhtar97 pushed a commit to nadimakhtar97/plots2 that referenced this pull request Sep 21, 2020
shubhangikori pushed a commit to shubhangikori/plots2 that referenced this pull request Oct 12, 2020
alvesitalo pushed a commit to alvesitalo/plots2 that referenced this pull request Oct 14, 2020
piyushswain pushed a commit to piyushswain/plots2 that referenced this pull request Oct 22, 2020
manchere pushed a commit to manchere/plots2 that referenced this pull request Feb 13, 2021
lagunasmel pushed a commit to lagunasmel/plots2 that referenced this pull request Mar 2, 2021
reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
ampwang pushed a commit to ampwang/plots2 that referenced this pull request Oct 26, 2021
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minify leaflet scripts using Uglifier
2 participants