-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change t to translation in dashboard/_comment_moderate #8509
Conversation
Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help. |
Code Climate has analyzed commit cede6f4 and detected 0 issues on this pull request. View more on Code Climate. |
Codecov Report
@@ Coverage Diff @@
## main #8509 +/- ##
==========================================
- Coverage 82.01% 81.89% -0.12%
==========================================
Files 101 101
Lines 5894 5894
==========================================
- Hits 4834 4827 -7
- Misses 1060 1067 +7
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, this looks great! Can you share a screenshot of the changes so we can just be sure it worked? You can do this by opening GitPod and it will boot up your changes!
Those definitely show that the site is running, which is great! Well if you are able to create an account and post a comment on the site that's running in Gitpod, and then, perhaps, log in with |
I was able to create a user account to test this change. I could add comments to an existing blog post. Then I logged in as admin and was given the option to the approve the comments. Once these buttons were clicked, the comments were added and no errors appeared. Is the function different for comments to questions? I wanted to add a comment to a question I added, but when I clicked the link to access that question, I saw this error: |
Hi, I think it should be the same but I believe this template is used only on the dashboard, when view it comments there! Can you try viewing your comment in that page and then your changes should appear! Thank you, much appreciated!! You're doing super well here! |
I still got an error when I logged out and tried to see the question. I wonder if this is related to being in the dev environment. I believe the initial issue is resolved. Let me know if there is anything else needed. Thank you! |
Oh, i'm so sorry, yes, this is something we're trying to resolve in #8499 because GitPod has trouble with those pages for some reason. I can download and run this in a couple days and will merge it then - thank you so much! |
Thank you! |
This is all good! Thank you so much!! |
Congrats on merging your first pull request! ππβ‘οΈ Help others take their first stepNow that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. π Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! π People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! π π Read about how to help support another newcomer here, or find other ways to offer mutual support here. |
Great work!!! |
Thank you, @jywarren! I saw that a comment was successfully posted two days ago on the stable dev site. (I tried to add a comment on that site a few days ago, but it is pending approval.) |
Fixes #6598
Changed the function named t(....) to be named as translation(...) on lines 4, 5, 6, and 8.
rake test