Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change t to translation in dashboard/_comment_moderate #8509

Merged
merged 1 commit into from
Oct 21, 2020

Conversation

ana-vela
Copy link
Contributor

@ana-vela ana-vela commented Oct 9, 2020

Fixes #6598

Changed the function named t(....) to be named as translation(...) on lines 4, 5, 6, and 8.

  • [ βœ…] PR is descriptively titled πŸ“‘ and links the original issue above πŸ”—
  • [βœ… ] tests pass -- look for a green checkbox βœ”οΈ a few minutes after opening your PR -- or run tests locally with rake test
  • [βœ… ] code is in uniquely-named feature branch and has no merge conflicts πŸ“

@welcome
Copy link

welcome bot commented Oct 9, 2020

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help πŸ’Ώ
There may be some errors, but don't worry! We'll work through them with you! πŸ‘πŸŽ‰πŸ˜„
It would be great if you can tell us your Twitter handle so we can thank you properly?

@gitpod-io
Copy link

gitpod-io bot commented Oct 9, 2020

@codeclimate
Copy link

codeclimate bot commented Oct 9, 2020

Code Climate has analyzed commit cede6f4 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Oct 9, 2020

Codecov Report

Merging #8509 into main will decrease coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8509      +/-   ##
==========================================
- Coverage   82.01%   81.89%   -0.12%     
==========================================
  Files         101      101              
  Lines        5894     5894              
==========================================
- Hits         4834     4827       -7     
- Misses       1060     1067       +7     
Impacted Files Coverage Ξ”
app/services/execute_search.rb 88.88% <0.00%> (-5.56%) ⬇️
app/api/srch/search.rb 66.87% <0.00%> (-3.83%) ⬇️

Copy link
Member

@jywarren jywarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, this looks great! Can you share a screenshot of the changes so we can just be sure it worked? You can do this by opening GitPod and it will boot up your changes!

@ana-vela
Copy link
Contributor Author

ana-vela commented Oct 9, 2020

Sure! When I connect with Gitpod, this is what I see. Is there something else I need to do? Or is a different screenshot needed? Thanks for your time!

public-lab-6598

public-lab-6598-1

@jywarren
Copy link
Member

jywarren commented Oct 9, 2020

Those definitely show that the site is running, which is great!

Well if you are able to create an account and post a comment on the site that's running in Gitpod, and then, perhaps, log in with admin/password to see what the comment looks like on the dashboard, we can see it in situ! But if you run into any trouble with that, I'm happy to give it a go as well. Thanks so much!

@ana-vela
Copy link
Contributor Author

I was able to create a user account to test this change. I could add comments to an existing blog post. Then I logged in as admin and was given the option to the approve the comments. Once these buttons were clicked, the comments were added and no errors appeared.

public-lab-approve-comment

public-lab-comments-approved

Is the function different for comments to questions? I wanted to add a comment to a question I added, but when I clicked the link to access that question, I saw this error:

public-lab-error

@jywarren
Copy link
Member

Hi, I think it should be the same but I believe this template is used only on the dashboard, when view it comments there! Can you try viewing your comment in that page and then your changes should appear!

Thank you, much appreciated!! You're doing super well here!

@ana-vela
Copy link
Contributor Author

I still got an error when I logged out and tried to see the question. I wonder if this is related to being in the dev environment. I believe the initial issue is resolved. Let me know if there is anything else needed. Thank you!

@jywarren
Copy link
Member

Oh, i'm so sorry, yes, this is something we're trying to resolve in #8499 because GitPod has trouble with those pages for some reason. I can download and run this in a couple days and will merge it then - thank you so much!

@ana-vela
Copy link
Contributor Author

Thank you!

@jywarren
Copy link
Member

This is all good! Thank you so much!!

@jywarren jywarren merged commit fc11ad2 into publiclab:main Oct 21, 2020
@welcome
Copy link

welcome bot commented Oct 21, 2020

Congrats on merging your first pull request! πŸ™ŒπŸŽ‰βš‘οΈ
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Do join our weekly check-in to share your this week goal and the awesome work you did πŸ˜ƒ. Please find the link pinned in the issue section πŸ“
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. πŸ™Œ

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! πŸ˜•

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! πŸ˜„ πŸŽ‰

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

@jywarren
Copy link
Member

Great work!!!

piyushswain pushed a commit to piyushswain/plots2 that referenced this pull request Oct 22, 2020
@ana-vela
Copy link
Contributor Author

Thank you, @jywarren! I saw that a comment was successfully posted two days ago on the stable dev site. (I tried to add a comment on that site a few days ago, but it is pending approval.)

Screen Shot 2020-10-26 at 7 38 11 AM

manchere pushed a commit to manchere/plots2 that referenced this pull request Feb 13, 2021
lagunasmel pushed a commit to lagunasmel/plots2 that referenced this pull request Mar 2, 2021
reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
ampwang pushed a commit to ampwang/plots2 that referenced this pull request Oct 26, 2021
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants