[System Tests] Comment Reply on Notes

[noi5e]

Prerequisite: Merge #8809 First!

• Add new fixtures for testing note comments:
  • node.yml
  • comment.yml
  • revision.yml
• New test:
  • find first comment ID (the new comment fixture)
  • POST new comment with addComment
  • assert that comment text exists

test 'note: respond to existing comment' do
  visit nodes(:comment_note).path
  # find comment ID of the first comment on page
  parent_id = "#" + page.find('#comments-list').first('.comment')[:id]
  # comment ID format is id="c9834"
  # regex to find everything after the "c"
  parent_id_num = /c(\d+)/.match(parent_id)[1] 
  # parameters for addComment: addComment(comment text, submitURL, comment's parent ID)
  page.evaluate_script("addComment(\"I admire you\", '/comment/create/#{nodes(:comment_note).nid}', #{parent_id_num})")
  # check for comment text
  assert_selector("#{parent_id} .comment .comment-body p", text: 'I admire you')
end

(This PR is part of the larger Comment Editor Overhaul Project with Outreachy. Refer to Planning Issue #9069 for more context)

[gitpod-io]

[jywarren]

Once we merge #8809, and resolve any conflicts here, can you confirm that this passes locally so we can do a final review before merging (and bypassing Travis for now)? Thank you!

[jywarren]

We can mark this with readytomerge as soon as we get conflicts resolved and local test passing confirmed. Thanks!

[noi5e]

@jywarren Thanks, just resolved the conflicts and ran all tests locally again, looks good on my end (no additional/distinct failures)

[jywarren]

Awesome, one more conflict resolution here, and we should be good to merge! Thank you! With all this happening, are you able to track the changes (i.e. check off items) in your main project issue as well? Just to keep us organized. Thanks @noi5e !!!

[jywarren]

Ah i see each PR has a line and they're getting crossed off in #8775 - perfect!!

[codeclimate]

Code Climate has analyzed commit 7f5b8a6 and detected 0 issues on this pull request.

View more on Code Climate.

[noi5e]

Did another conflict resolve, so it should be ready!

I know it's getting a bit messy, I'll do a big organization and renaming of things after I have a decent set of tests.

[jywarren]

Awesome. Thanks again!!!! Probably best to run local tests one more time just to confirm after all the merging, deconflicting, etc.

Thanks a ton! I appreciate the extra time it took to get these organized given the Travis outage. 🙌