Reduced response time in nearby People search API

[17sushmita]

Fixes #7556

• PR is descriptively titled 📑 and links the original issue above 🔗
• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
• code is in a uniquely-named feature branch and has no merge conflicts 📁
• screenshots/GIFs are attached 📎 in case of UI updation
• ask @publiclab/reviewers for help, in a comment below

Before -

GET: https://publiclab.org/api/srch/nearbyPeople?nwlat=10.0&selat=0.0&nwlng=0.0&selng=10.0
Time: 39.36

After -

GET: https://unstable.publiclab.org/api/srch/nearbyPeople?nwlat=10.0&selat=0.0&nwlng=0.0&selng=10.0
Time : 2.12s

[gitpod-io]

[daemon1024]

Wow 👀 So we don't need to deal with n+1 problem at all?

[codeclimate]

Code Climate has analyzed commit ccb5e78 and detected 0 issues on this pull request.

View more on Code Climate.

[codecov]

Codecov Report

Merging #9940 (ccb5e78) into main (b73594f) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #9940      +/-   ##
==========================================
- Coverage   82.13%   82.13%   -0.01%     
==========================================
  Files          98       98              
  Lines        5968     5966       -2     
==========================================
- Hits         4902     4900       -2     
  Misses       1066     1066              

Impacted Files	Coverage Δ
app/services/search_service.rb	95.00% <100.00%> (-0.10%)	⬇️

[17sushmita]

Wow So we don't need to deal with n+1 problem at all?

Ah! I didn't see the discussion on the main issue. Let's think of improving the performance furthermore. Currently looping over every node by the user to check if it has location: blurred was really slow so this can be simply improved by using a rails query.

[daemon1024]

Yeah we need to analyse further but in my opinion maybe we should proceed with merging this, since this is a significant improvement ( Significant as in Huge :O ) Can work on others in subsequent PRs as we proceed with discussion at #7556

[jywarren]

awesomeeeee

[jywarren]

Very excited for this!