Add basic functionality for heat behavior #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryzokuken
changed the title
|
Super! |
ryzokuken
force-pushed
the
feature-chatops-temp
branch
from
8f93315 to
a220641
Compare
|
Done with regard to #65 |
|
This looks good. Once you are done with the tests we can merge this. |
|
I cannot find a decent way to test this behaviour, help me.
…On Fri 11 Aug, 2017, 4:39 PM Ananyo Maiti, ***@***.***> wrote:
This looks good. Once you are done with the tests we can merge this.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#67 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AMg3MqfVdtAczP7_ELOI6DrbtkZy8z7xks5sXDZRgaJpZM4Oz0qt>
.
|
|
With respect to the promise written in #66 just make a method that will mock the execution of the process and make the promise reject or resolve. |
|
Cleverly done! |
|
This is a really good self-contained example of an entire behavior -- maybe we should link to this from the README as an example of everything you need to add a behavior? |
|
@jywarren Sure, I will do that right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to merge #66 first though.