Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use of triple equals instead of double equals #92

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use of triple equals instead of double equals #92

wants to merge 1 commit into from

Conversation

priyansh1161
Copy link

@priyansh1161 priyansh1161 commented Nov 6, 2017 •
edited
Loading

triple equal should have been used in place of double equals.

P.S Should we set up eslint for this project?

@priyansh1161
Use of triple equals instead of double equals
e6eafa6 
triple equal should have been used in place of double equals.

P.s For more such issues should we set up eslint for this project?
@coveralls
Copy link

coveralls commented Nov 6, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 94.118% when pulling e6eafa6 on priyansh1161:patch-1 into 5e74c89 on publiclab:master.

@ryzokuken
Copy link
Member

Wait, we don't already have ESLint?

P.S. We do!
https://github.com/publiclab/plotsbot/blob/master/.eslintrc

@jywarren jywarren changed the base branch from master to main June 24, 2020 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jywarren jywarren Awaiting requested review from jywarren

@ryzokuken ryzokuken Awaiting requested review from ryzokuken

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@priyansh1161 @coveralls @ryzokuken