Skip to content

Commit

Permalink
Merge pull request #166 from pubnub/develop
Browse files Browse the repository at this point in the history
Release v4.25.2
  • Loading branch information
raipubnub authored Sep 4, 2019
2 parents 9f6fc98 + 5cc45d7 commit 87f2a6b
Show file tree
Hide file tree
Showing 14 changed files with 43 additions and 24 deletions.
9 changes: 8 additions & 1 deletion .pubnub.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
---
changelog:
-
changes:
-
text: "Fix issue with subdomains ending in 'ps'"
type: bug
date: 2019-09-03
version: v4.25.2
-
changes:
-
Expand Down Expand Up @@ -723,4 +730,4 @@ supported-platforms:
- "Ubuntu 14.04 and above"
- "Windows 7, 8, 10"
version: "Pubnub Javascript for Node"
version: "4.25.1"
version: "4.25.2"
20 changes: 16 additions & 4 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,12 +1,24 @@
## [v4.25.1](https://github.com/pubnub/javascript/tree/v4.25.1)
## [v4.25.2](https://github.com/pubnub/javascript/tree/v4.25.2)
August-23-2019


[Full Changelog](https://github.com/pubnub/javascript/compare/v4.25.1...v4.25.2)



- ⭐ Fix issue with subdomains ending in 'ps'



## [v4.25.1](https://github.com/pubnub/javascript/tree/v4.25.1)
August-23-2019


[Full Changelog](https://github.com/pubnub/javascript/compare/v4.25.0...v4.25.1)



- ⭐ Fix regression: Fix titanium build to support recent version"
- ⭐ Fix regression: Fix titanium build to support recent version



Expand All @@ -18,7 +30,7 @@



- ⭐ Fix regression: Add Objects support for Users, Spaces and Memberships"
- ⭐ Fix regression: Add Objects support for Users, Spaces and Memberships



Expand All @@ -30,7 +42,7 @@



- ⭐ Fix regression: 'PubNub is not a constructor' in Node.js"
- ⭐ Fix regression: 'PubNub is not a constructor' in Node.js



Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,5 +22,5 @@ please use the [master_3x](https://github.com/pubnub/javascript/tree/master_3x)



* https://cdn.pubnub.com/sdk/javascript/pubnub.4.25.1.min.js
* https://cdn.pubnub.com/sdk/javascript/pubnub.4.25.1.js
* https://cdn.pubnub.com/sdk/javascript/pubnub.4.25.2.min.js
* https://cdn.pubnub.com/sdk/javascript/pubnub.4.25.2.js
4 changes: 2 additions & 2 deletions dist/titanium/pubnub.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/titanium/pubnub.min.js

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions dist/web/pubnub.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/web/pubnub.min.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion lib/core/components/config.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/core/components/config.js.map

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions lib/networking/index.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/networking/index.js.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "pubnub",
"version": "4.25.1",
"version": "4.25.2",
"author": "PubNub <support@pubnub.com>",
"description": "Publish & Subscribe Real-time Messaging with PubNub",
"bin": {},
Expand Down
2 changes: 1 addition & 1 deletion src/core/components/config.js
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,7 @@ export default class {
}

getVersion(): string {
return '4.25.1';
return '4.25.2';
}

_decideUUID(providedUUID: string): string {
Expand Down
8 changes: 4 additions & 4 deletions src/networking/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ export default class {

nextOrigin(): string {
// if a custom origin is supplied, use do not bother with shuffling subdomains
if (this._providedFQDN.indexOf('ps.') === -1) {
if (!this._providedFQDN.match(/ps\.pndsn\.com$/i)) {
return this._providedFQDN;
}

Expand All @@ -59,9 +59,9 @@ export default class {
newSubDomain = this._currentSubDomain.toString();

return this._providedFQDN.replace(
'ps.',
`ps${newSubDomain}.`
); /* ensure ps. is used to replace, else https text will change */
'ps.pndsn.com',
`ps${newSubDomain}.pndsn.com`
);
}

hasModule(name: string) {
Expand Down

0 comments on commit 87f2a6b

Please sign in to comment.