Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typings for new features (Event Engine & Listeners) #377

Closed
roman-rr opened this issue May 24, 2024 · 1 comment · Fixed by #417
Closed

Typings for new features (Event Engine & Listeners) #377

roman-rr opened this issue May 24, 2024 · 1 comment · Fixed by #417
Assignees
@parfeon
Labels
priority: medium This PR should be reviewed after all high priority PRs. status: in progress This issue is being worked on. type: chore This PR contains changes that are not covered by other types (stylistic, dependency updates, etc).

Comments

@roman-rr
Copy link

Hello everyone.

Could someone please help to update typings:
https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/pubnub

Latest version is "@types/pubnub": "7.4.2" and PubNub "pubnub": "8.0.1".

Especially need to have new methods from new Event Engine & Listeners, such as subscriptionSet.

Thanks.
@parfeon parfeon self-assigned this Oct 30, 2024
@parfeon parfeon added status: in progress This issue is being worked on. priority: medium This PR should be reviewed after all high priority PRs. type: chore This PR contains changes that are not covered by other types (stylistic, dependency updates, etc). labels Oct 30, 2024
parfeon added a commit that referenced this issue Oct 30, 2024
@parfeon
fix(types): fix Actions type definition
c607f93 
Fix definition of type which represent message actions received from history and list of users which added action of specific type and value to the message.

Closes #407

refactor(types): remove indexed signature for publish

Remove redundant indexed signature from publish message parameters type definition.

Closes #413

refactor(types): add serializable objects to `Payload` type

Extend `Payload` type definition with objects which can be serialized by `JSON.stringify` using `toJSON()` methods.

Closes #412

refactor(types): aggregate generated types definitions

Aggregate multiple types definitions into single type definition type with proper type names and namespaces.

Closes #405 #409 #410

refactor(types): add missing Subscribe Event Engine types

Add Subscribe Event Engine and Event Listener types to the bundled types definition file.

Closes #377
@parfeon parfeon mentioned this issue Oct 30, 2024
Merged
@parfeon
Copy link
Contributor

parfeon commented Oct 31, 2024

@roman-rr this issue is addressed in v8.2.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@parfeon parfeon

Labels
priority: medium This PR should be reviewed after all high priority PRs. status: in progress This issue is being worked on. type: chore This PR contains changes that are not covered by other types (stylistic, dependency updates, etc).
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix types definition issues pubnub/javascript
2 participants
@parfeon @roman-rr