Fix types definition issues #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix definition of type which represent message actions received from history and list of users which added action of specific type and value to the message. Closes #407 refactor(types): remove indexed signature for publish Remove redundant indexed signature from publish message parameters type definition. Closes #413 refactor(types): add serializable objects to `Payload` type Extend `Payload` type definition with objects which can be serialized by `JSON.stringify` using `toJSON()` methods. Closes #412 refactor(types): aggregate generated types definitions Aggregate multiple types definitions into single type definition type with proper type names and namespaces. Closes #405 #409 #410 refactor(types): add missing Subscribe Event Engine types Add Subscribe Event Engine and Event Listener types to the bundled types definition file. Closes #377
parfeon
added
status: done
mohitpubnub
approved these changes
Oct 31, 2024
| @@ -0,0 +1,803 @@ | |||
| import { program } from 'commander'; | |||
|
@pubnub-release-bot release |
pubnub-release-bot
requested review from
techwritermat and
kazydek
as code owners
|
🚀 Release successfully completed 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(types): fix
Actionstype definitionFix definition of type which represents message actions received from history and list of users which added action of specific type and value to the message.
Closes #407
refactor(types): remove indexed signature for publish
Remove redundant indexed signature from publish message parameters type definition.
Closes #413
refactor(types): add serializable objects to
PayloadtypeExtend
Payloadtype definition with objects which can be serialized byJSON.stringifyusingtoJSON()methods.Closes #412
refactor(types): aggregate generated types definitions
Aggregate multiple types definitions into single type definition type with proper type names and namespaces.
Closes #405 #409 #410
refactor(types): add missing Subscribe Event Engine types
Add the Subscribe Event Engine and Event Listener types to the bundled types definition file.
Closes #377