Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Subscription entity's subscribe() signature to accept timetoken #385

Merged
merged 7 commits into from
Jun 17, 2024
Merged

fix: Subscription entity's subscribe() signature to accept timetoken #385

merged 7 commits into from
Jun 17, 2024

Conversation

mohitpubnub
Copy link
Contributor

@mohitpubnub mohitpubnub commented Jun 17, 2024 •
edited
Loading

fix: subscribe() method accepting timetoken param.

Subscription/SubscriptionSet's subscribe() method accepts timetoken parameter. Instead as in subscriptionOption.

@mohitpubnub mohitpubnub self-assigned this Jun 17, 2024
@mohitpubnub mohitpubnub added status: done This issue is considered resolved. type: bug This issue reports a bug. priority: high This PR should be reviewed ASAP. labels Jun 17, 2024
@mohitpubnub mohitpubnub changed the title fix: subscribe() signature to accept timetoken fix: Subscription entity's subscribe() signature to accept timetoken Jun 17, 2024
parfeon
parfeon approved these changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@parfeon parfeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mohitpubnub
Copy link
Contributor Author

@pubnub-release-bot release

@mohitpubnub
Copy link
Contributor Author

@pubnub-release-bot release

@mohitpubnub mohitpubnub merged commit 5dc7ec7 into master Jun 17, 2024
7 checks passed
@mohitpubnub mohitpubnub deleted the fix/subscribe-timetoken branch June 17, 2024 13:56
@pubnub-release-bot
Copy link
Contributor

🚀 Release successfully completed 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parfeon parfeon parfeon approved these changes

@seba-aln seba-aln Awaiting requested review from seba-aln seba-aln is a code owner

@techwritermat techwritermat Awaiting requested review from techwritermat techwritermat is a code owner

@kazydek kazydek Awaiting requested review from kazydek kazydek is a code owner

Assignees

@mohitpubnub mohitpubnub

Labels
priority: high This PR should be reviewed ASAP. status: done This issue is considered resolved. type: bug This issue reports a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mohitpubnub @pubnub-release-bot @parfeon