Fix / revert fetch TypeError handling
#415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert fix created to handle browser timeouts (not gracefully). The Web Fetch API doesn't have descriptive error information, and it sends `TypeError` for both cases when connection closed by browser or network issue (blocked domain).
parfeon
added
status: done
mohitpubnub
reviewed
Oct 25, 2024
| @@ -58,9 +58,7 @@ export class PubNubAPIError extends Error { | |||
| category = StatusCategory.PNNetworkIssuesCategory; | |||
| message = 'Network issues'; | |||
| } else if (errorName === 'TypeError') { | |||
| if (message.indexOf('Load failed') !== -1 || message.indexOf('Failed to fetch') != -1) | |||
mohitpubnub
approved these changes
Oct 25, 2024
|
@pubnub-release-bot release |
pubnub-release-bot
requested review from
techwritermat and
kazydek
as code owners
|
🚀 Release successfully completed 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(subscribe): fix / revert
fetchTypeErrorhandlingRevert fix created to handle browser timeouts (not gracefully). The Web Fetch API doesn't have descriptive error information, and it sends
TypeErrorfor both cases when connection closed by browser or network issue (blocked domain).Closes