Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for is_error #102

Closed
wants to merge 1 commit into from
Closed

Fix for is_error #102

wants to merge 1 commit into from

Conversation

natekspencer
Copy link

This fixes the check for is_error when it is set to False instead of None.
There were also 2 places where ".is_error" was called instead of ".is_error()"

@650elx
Copy link
Contributor

650elx commented Apr 16, 2021 •
edited
Loading

@natekspencer Once again big thanks for your contribution 💪
I'll test this code and I'll try to include it into one of the next releases.

@650elx 650elx self-requested a review April 16, 2021 11:19
@650elx 650elx added the status: accepted This issue is accepted as valid, but it's not being worked on yet. label Apr 16, 2021
@650elx 650elx requested a review from bartk as a code owner November 4, 2021 13:45
seba-aln added a commit that referenced this pull request Nov 21, 2022
@seba-aln
Add urls to PyPi package
2b446d9 
Closes #115

Fix for is_error

Closes #102
@seba-aln seba-aln mentioned this pull request Nov 21, 2022
Merged
seba-aln added a commit that referenced this pull request Nov 24, 2022
@seba-aln @client-engineering-bot
Fixes for various errors (#146)
8ee850b 
* Fix typo in consumer models

Closes #145

* Add urls to PyPi package

Closes #115

Fix for is_error

Closes #102

* Typo and a shorthand

* PubNub SDK 7.0.2 release.

Co-authored-by: Client Engineering Bot <60980775+client-engineering-bot@users.noreply.github.com>
@pn-op
Copy link

pn-op commented Nov 24, 2022

@natekspencer this issue is addressed in 7.0.2

@github-actions github-actions bot added status: done This issue is considered resolved. and removed status: accepted This issue is accepted as valid, but it's not being worked on yet. labels Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@650elx 650elx Awaiting requested review from 650elx

@bartk bartk Awaiting requested review from bartk

@seba-aln seba-aln Awaiting requested review from seba-aln seba-aln is a code owner

@kleewho kleewho Awaiting requested review from kleewho

Assignees
No one assigned
Labels
status: done This issue is considered resolved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@natekspencer @650elx @pn-op