Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows artifact arguements updates #112

Merged
merged 2 commits into from
Feb 16, 2024
Merged

Windows artifact arguements updates #112

merged 2 commits into from
Feb 16, 2024

Conversation

puffyCid
Copy link
Owner

This PR udates the optional arguements for Windows artifacts.

Instead of supporting both alt-drive, alt-file, or alt-dir optional arguements.
Most artifacts will now only accept alt-file or alt-dir optional arguements.

Basically, this PR removes the optional alt-drive arguement for all artifacts except UsnJrnl and filelistings
Fixes #107

Copy link

codecov bot commented Feb 15, 2024

Codecov Report

Attention: 95 lines in your changes are missing coverage. Please review.

Comparison is base (b4a10b9) 83.96% compared to head (c7d42a8) 83.83%.

Files Patch % Lines
...-core/src/artifacts/os/windows/shellbags/parser.rs 62.38% 41 Missing ⚠️
...emis-core/src/artifacts/os/windows/tasks/parser.rs 32.14% 19 Missing ⚠️
...core/src/artifacts/os/windows/recyclebin/parser.rs 54.54% 5 Missing ⚠️
...s-core/src/artifacts/os/windows/registry/parser.rs 58.33% 5 Missing ⚠️
...-core/src/artifacts/os/windows/jumplists/parser.rs 60.00% 4 Missing ⚠️
cli/src/collector/windows.rs 90.24% 4 Missing ⚠️
...re/src/artifacts/os/windows/userassist/registry.rs 88.88% 3 Missing ⚠️
...mis-core/src/artifacts/os/windows/shimdb/parser.rs 81.81% 2 Missing ⚠️
artemis-core/src/artifacts/os/windows/artifacts.rs 92.85% 1 Missing ⚠️
...-core/src/artifacts/os/windows/eventlogs/parser.rs 87.50% 1 Missing ⚠️
... and 10 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #112      +/-   ##
==========================================
- Coverage   83.96%   83.83%   -0.13%     
==========================================
  Files         448      448              
  Lines       51376    51274     -102     
==========================================
- Hits        43138    42986     -152     
- Misses       8238     8288      +50     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@puffyCid puffyCid merged commit 3cfde56 into main Feb 16, 2024
7 of 10 checks passed
@puffyCid puffyCid deleted the arguements-update branch February 16, 2024 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review whether to use alt_drive or alt_path (or both)
1 participant