Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce clone usage #213

Merged
merged 9 commits into from
Dec 26, 2024
Merged

Reduce clone usage #213

merged 9 commits into from
Dec 26, 2024

Conversation

puffyCid
Copy link
Owner

Removes some unnecessary clone usage. Also made some changes on how artemis writes output.

Should lower memory usage quite a bit

Copy link

codecov bot commented Dec 25, 2024

Codecov Report

Attention: Patch coverage is 89.52880% with 40 lines in your changes missing coverage. Please review.

Project coverage is 85.23%. Comparing base (e431ca3) to head (91ae849).

Files with missing lines Patch % Lines
core/src/artifacts/os/windows/search/ese.rs 0.00% 16 Missing ⚠️
core/src/artifacts/os/windows/eventlogs/parser.rs 63.63% 4 Missing ⚠️
...rc/artifacts/os/windows/search/tables/indexgthr.rs 0.00% 4 Missing ⚠️
core/src/output/formats/jsonl.rs 95.23% 4 Missing ⚠️
core/src/artifacts/os/linux/journals/journal.rs 50.00% 2 Missing ⚠️
core/src/artifacts/os/windows/artifacts.rs 93.93% 2 Missing ⚠️
core/src/artifacts/os/windows/search/sqlite.rs 50.00% 2 Missing ⚠️
core/src/utils/compression/compress.rs 89.47% 2 Missing ⚠️
cli/src/collector/system.rs 97.56% 1 Missing ⚠️
core/src/artifacts/os/macos/unified_logs/logs.rs 83.33% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #213      +/-   ##
==========================================
+ Coverage   85.16%   85.23%   +0.06%     
==========================================
  Files         490      490              
  Lines       64766    64681      -85     
==========================================
- Hits        55159    55128      -31     
+ Misses       9607     9553      -54     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@puffyCid puffyCid merged commit 7c3ee74 into main Dec 26, 2024
7 checks passed
@puffyCid puffyCid deleted the reduce-clone branch December 26, 2024 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant